New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-35244][SQL][FOLLOWUP] Add null check for the exception cause #32387

Closed

cloud-fan wants to merge 1 commit into apache:master from cloud-fan:minor

Contributor

cloud-fan commented Apr 28, 2021

What changes were proposed in this pull request?

Make sure we re-throw an exception that is not null.

Why are the changes needed?

to be super safe

Does this PR introduce any user-facing change?

no

How was this patch tested?

N/A


          add null check for the exception cause

5cfb3c2

Contributor Author

cloud-fan commented Apr 28, 2021

cc @maropu @yaooqinn

github-actions bot added the SQL label

SparkQA commented Apr 28, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42571/

SparkQA commented Apr 28, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42571/

SparkQA commented Apr 28, 2021

Test build #138052 has finished for PR 32387 at commit 5cfb3c2.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins commented Apr 28, 2021

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138052/

maropu approved these changes

View reviewed changes

maropu closed this in

403e479

Member

maropu commented Apr 29, 2021

Thank you. Merged to master.

Member

yaooqinn commented Apr 29, 2021

late LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

SQL