[SPARK-35292][PYTHON] Delete redundant parameter in mypy configuration #32418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @zero323 FYI |
|
@garawalid, would you mind taking a look for https://github.com/apache/spark/pull/32418/checks?check_run_id=2487946353 and enable GitHub Actions please? Apache Spark leverages forked repository's GItHub Actions for building and testing the changes in the PR. |
garawalid
force-pushed
the
feature/clean-mypy-config
branch
from
951858a
to
783131b
Compare
|
@HyukjinKwon, thanks for pointing this out, it's done. |
|
Jenkins retest this please |
srowen
approved these changes
May 3, 2021
zero323
approved these changes
May 3, 2021
HyukjinKwon
approved these changes
May 4, 2021
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The parameter no_implicit_optional is defined twice in the mypy configuration, ligne 20 and ligne 105.
Why are the changes needed?
We would like to keep the mypy configuration clean.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
This patch can be tested with
dev/lint-python