[SPARK-35302][INFRA] Benchmark workflow should create new files for new benchmarks #32428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is still being tested. I will make it ready-of-reivew when all tests pass properly. |
|
I am 100% sure this is correct - also it doesn't affect anything the actual tests or main codes. Please let me merge this and proceed because I am running benchmarks now to verify. |
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently, it fails at
git diff --name-onlywhen new benchmarks are added, see https://github.com/HyukjinKwon/spark/actions/runs/808870999We should include untracked files (new benchmark result files) to upload so developers download the results.
Why are the changes needed?
So the new benchmark results can be added and uploaded.
Does this PR introduce any user-facing change?
No, dev-only
How was this patch tested?
Tested at:
https://github.com/HyukjinKwon/spark/actions/runs/808867285