[SPARK-35358][BUILD] Increase maximum Java heap used for release build to avoid OOM #32487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
changed the title
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
dev/create-release/release-build.sh
Outdated
| @@ -210,6 +210,8 @@ if [[ "$1" == "package" ]]; then | |||
| PYSPARK_VERSION=`echo "$SPARK_VERSION" | sed -e "s/-/./" -e "s/SNAPSHOT/dev0/" -e "s/preview/dev/"` | |||
| echo "__version__='$PYSPARK_VERSION'" > python/pyspark/version.py | |||
|
|
|||
| export MAVEN_OPTS="-Xmx12000m" | |||
There was a problem hiding this comment.
Can we have this globally outside of if statement? Then, it looks like we need only one line addition.
|
Also, cc @srowen |
|
Test build #138310 has finished for PR 32487 at commit
|
|
Getting pretty big! but OK if needed. |
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Test build #138314 has finished for PR 32487 at commit
|
|
retest this please |
HyukjinKwon
approved these changes
May 10, 2021
cloud-fan
approved these changes
May 10, 2021
|
Kubernetes integration test unable to build dist. exiting with code: 1 |
dongjoon-hyun
approved these changes
May 10, 2021
dongjoon-hyun
pushed a commit
that referenced
this pull request
May 10, 2021
…d to avoid OOM ### What changes were proposed in this pull request? This patch proposes to increase the maximum heap memory setting for release build. ### Why are the changes needed? When I was cutting RCs for 2.4.8, I frequently encountered OOM during building using mvn. It happens many times until I increased the heap memory setting. I am not sure if other release managers encounter the same issue. So I propose to increase the heap memory setting and see if it looks good for others. ### Does this PR introduce _any_ user-facing change? No, dev only. ### How was this patch tested? Manually used it during cutting RCs of 2.4.8. Closes #32487 from viirya/release-mvn-oom. Authored-by: Liang-Chi Hsieh <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 20d3224) Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun
pushed a commit
that referenced
this pull request
May 10, 2021
…d to avoid OOM ### What changes were proposed in this pull request? This patch proposes to increase the maximum heap memory setting for release build. ### Why are the changes needed? When I was cutting RCs for 2.4.8, I frequently encountered OOM during building using mvn. It happens many times until I increased the heap memory setting. I am not sure if other release managers encounter the same issue. So I propose to increase the heap memory setting and see if it looks good for others. ### Does this PR introduce _any_ user-facing change? No, dev only. ### How was this patch tested? Manually used it during cutting RCs of 2.4.8. Closes #32487 from viirya/release-mvn-oom. Authored-by: Liang-Chi Hsieh <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 20d3224) Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 9623ccb) Signed-off-by: Dongjoon Hyun <[email protected]>
|
Merged to master/3.1/3.0. |
|
Test build #138322 has finished for PR 32487 at commit
|
|
Test build #138323 has finished for PR 32487 at commit
|
|
Thanks all! |
flyrain
pushed a commit
to flyrain/spark
that referenced
this pull request
Sep 21, 2021
…d to avoid OOM ### What changes were proposed in this pull request? This patch proposes to increase the maximum heap memory setting for release build. ### Why are the changes needed? When I was cutting RCs for 2.4.8, I frequently encountered OOM during building using mvn. It happens many times until I increased the heap memory setting. I am not sure if other release managers encounter the same issue. So I propose to increase the heap memory setting and see if it looks good for others. ### Does this PR introduce _any_ user-facing change? No, dev only. ### How was this patch tested? Manually used it during cutting RCs of 2.4.8. Closes apache#32487 from viirya/release-mvn-oom. Authored-by: Liang-Chi Hsieh <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 20d3224) Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch proposes to increase the maximum heap memory setting for release build.
Why are the changes needed?
When I was cutting RCs for 2.4.8, I frequently encountered OOM during building using mvn. It happens many times until I increased the heap memory setting.
I am not sure if other release managers encounter the same issue. So I propose to increase the heap memory setting and see if it looks good for others.
Does this PR introduce any user-facing change?
No, dev only.
How was this patch tested?
Manually used it during cutting RCs of 2.4.8.