[SPARK-35377][INFRA] Add JS linter to GA #32512
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
approved these changes
May 12, 2021
HyukjinKwon
reviewed
May 12, 2021
.github/workflows/build_and_test.yml
Outdated
| @@ -356,6 +356,10 @@ jobs: | |||
| Rscript -e "install.packages(c('devtools'), repos='https://cloud.r-project.org/')" | |||
| Rscript -e "devtools::install_github('jimhester/[email protected]')" | |||
| ./R/install-dev.sh | |||
| - name: Instll JS linter dependencies | |||
There was a problem hiding this comment.
Should we rename JS -> JavaScript?
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Kubernetes integration test unable to build dist. exiting with code: 1 |
|
Test build #138417 has finished for PR 32512 at commit
|
|
Test build #138425 has finished for PR 32512 at commit
|
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
SPARK-35175 (#32274) added a linter for JS so let's add it to GA.
Why are the changes needed?
To JS code keep clean.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
GA