[SPARK-35394][K8S][BUILD] Move kubernetes-client.version to root pom file #32531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you review this, @attilapiros ? |
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
The Python module UT failure is SPARK-35392 and will be fixed in master branch via #32533 . |
|
Test build #138491 has finished for PR 32531 at commit
|
|
Hi, @HyukjinKwon . Could you review this PR please? |
|
Oh, thank you so much, @viirya ! |
|
LGTM2 |
|
Thank you, @HyukjinKwon ! |
|
LGTM |
|
Thank you, @attilapiros ! |
flyrain
pushed a commit
to flyrain/spark
that referenced
this pull request
Sep 21, 2021
…file This PR aims to unify two K8s version variables in two `pom.xml`s into one. `kubernetes-client.version` is correct because the artifact ID is `kubernetes-client`. ``` kubernetes.client.version (kubernetes/core module) kubernetes-client.version (kubernetes/integration-test module) ``` Having two variables for the same value is confusing and inconvenient when we upgrade K8s versions. No. Pass the CIs. (The compilation test passes are enough.) Closes apache#32531 from dongjoon-hyun/SPARK-35394. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to unify two K8s version variables in two
pom.xmls into one.kubernetes-client.versionis correct because the artifact ID iskubernetes-client.Why are the changes needed?
Having two variables for the same value is confusing and inconvenient when we upgrade K8s versions.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs. (The compilation test passes are enough.)