Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-34764][UI][FOLLOW-UP] Fix indentation and missing arguments for JavaScript linter #32541

Closed
wants to merge 1 commit into from

Conversation

HyukjinKwon
Copy link
Member

What changes were proposed in this pull request?

This PR is a followup of #32436 which broke JavaScript linter. There was a logical conflict - the linter was added after the last successful test run in that PR.

added 118 packages in 1.482s

/__w/spark/spark/core/src/main/resources/org/apache/spark/ui/static/executorspage.js
   34:41  error  'type' is defined but never used. Allowed unused args must match /^_ignored_.*/u  no-unused-vars
   34:47  error  'row' is defined but never used. Allowed unused args must match /^_ignored_.*/u   no-unused-vars
   35:1   error  Expected indentation of 2 spaces but found 4                                      indent
   36:1   error  Expected indentation of 4 spaces but found 7                                      indent
   37:1   error  Expected indentation of 2 spaces but found 4                                      indent
   38:1   error  Expected indentation of 4 spaces but found 7                                      indent
   39:1   error  Expected indentation of 2 spaces but found 4                                      indent
  556:1   error  Expected indentation of 14 spaces but found 16                                    indent
  557:1   error  Expected indentation of 14 spaces but found 16                                    indent

Why are the changes needed?

To recover the build

Does this PR introduce any user-facing change?

No, dev-only.

How was this patch tested?

Manually tested:

 ./dev/lint-js
lint-js checks passed.

@HyukjinKwon
Copy link
Member Author

cc @holdenk @sarutak

@HyukjinKwon HyukjinKwon changed the title [SPARK-34764][UI][FOLLOW-UP] Fix indentation for JavaScript linter [SPARK-34764][UI][FOLLOW-UP] Fix indentation and missing arguments for JavaScript linter May 14, 2021
Copy link
Member

@sarutak sarutak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Pending GA.

Copy link
Contributor

@holdenk holdenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this 👍

@SparkQA
Copy link

SparkQA commented May 14, 2021

Kubernetes integration test unable to build dist.

exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43056/

@sarutak
Copy link
Member

sarutak commented May 14, 2021

JavaScript linter passed. Merging to master.

@sarutak sarutak closed this in f7af9ab May 14, 2021
@HyukjinKwon
Copy link
Member Author

Thanks all!

@SparkQA
Copy link

SparkQA commented May 14, 2021

Test build #138534 has finished for PR 32541 at commit 69a08ac.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon HyukjinKwon deleted the SPARK-34764-followup branch January 4, 2022 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants