-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-36171][BUILD] Upgrade GenJavadoc to 0.18 #33383
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
approved these changes
Jul 16, 2021
dongjoon-hyun
approved these changes
Jul 16, 2021
GitHub Action Linter and documentation job passed. Merged to master/3.2. |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Jul 16, 2021
### What changes were proposed in this pull request? This PR upgrades `GenJavadoc` plugin from `0.17` to `0.18`. ### Why are the changes needed? `0.18` includes a bug fix for `Scala 2.13`. ``` This release fixes a bug (#286) with Scala 2.13.6 in relation with deprecated annotations in Scala sources leading to a NoSuchElementException in some cases. ``` https://github.com/lightbend/genjavadoc/releases/tag/v0.18 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Built the doc for Scala 2.13. ``` build/sbt -Phive -Phive-thriftserver -Pyarn -Pmesos -Pkubernetes -Phadoop-cloud -Pspark-ganglia-lgpl -Pkinesis-asl -Pdocker-integration-tests -Pkubernetes-integration-tests -Pscala-2.13 unidoc ``` Closes #33383 from sarutak/upgrade-genjavadoc-0.18. Authored-by: Kousuke Saruta <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit ad744fb) Signed-off-by: Dongjoon Hyun <[email protected]>
Kubernetes integration test starting |
Kubernetes integration test status success |
Test build #141113 has finished for PR 33383 at commit
|
LuciferYang
pushed a commit
that referenced
this pull request
May 15, 2024
### What changes were proposed in this pull request? This PR upgrades `GenJavadoc` plugin from `0.18` to `0.19`. ### Why are the changes needed? 1.The full release notes: https://github.com/lightbend/genjavadoc/releases/tag/v0.19 2.The latest version supports scala `2.13.14`, which is a `prerequisite` for us to upgrade spark's scala `2.13.14`. https://mvnrepository.com/artifact/com.typesafe.genjavadoc/genjavadoc-plugin 3.The last upgrade occurred 3 years ago #33383 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Built the doc: ``` ./build/sbt -Phadoop-3 -Pkubernetes -Pkinesis-asl -Phive-thriftserver -Pdocker-integration-tests -Pyarn -Phadoop-cloud -Pspark-ganglia-lgpl -Phive -Pjvm-profiler unidoc ``` <img width="501" alt="image" src="https://github.com/apache/spark/assets/15246973/58d3fac8-c968-44e0-83f3-84cf00a5084f"> ### Was this patch authored or co-authored using generative AI tooling? No. Closes #46579 from panbingkun/unidocGenjavadocVersion_0_19. Authored-by: panbingkun <[email protected]> Signed-off-by: yangjie01 <[email protected]>
szehon-ho
pushed a commit
to szehon-ho/spark
that referenced
this pull request
Aug 7, 2024
### What changes were proposed in this pull request? This PR upgrades `GenJavadoc` plugin from `0.18` to `0.19`. ### Why are the changes needed? 1.The full release notes: https://github.com/lightbend/genjavadoc/releases/tag/v0.19 2.The latest version supports scala `2.13.14`, which is a `prerequisite` for us to upgrade spark's scala `2.13.14`. https://mvnrepository.com/artifact/com.typesafe.genjavadoc/genjavadoc-plugin 3.The last upgrade occurred 3 years ago apache#33383 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Built the doc: ``` ./build/sbt -Phadoop-3 -Pkubernetes -Pkinesis-asl -Phive-thriftserver -Pdocker-integration-tests -Pyarn -Phadoop-cloud -Pspark-ganglia-lgpl -Phive -Pjvm-profiler unidoc ``` <img width="501" alt="image" src="https://github.com/apache/spark/assets/15246973/58d3fac8-c968-44e0-83f3-84cf00a5084f"> ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#46579 from panbingkun/unidocGenjavadocVersion_0_19. Authored-by: panbingkun <[email protected]> Signed-off-by: yangjie01 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR upgrades
GenJavadoc
plugin from0.17
to0.18
.Why are the changes needed?
0.18
includes a bug fix forScala 2.13
.https://github.com/lightbend/genjavadoc/releases/tag/v0.18
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Built the doc for Scala 2.13.