Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-36171][BUILD] Upgrade GenJavadoc to 0.18 #33383

Closed
wants to merge 1 commit into from

Conversation

sarutak
Copy link
Member

@sarutak sarutak commented Jul 16, 2021

What changes were proposed in this pull request?

This PR upgrades GenJavadoc plugin from 0.17 to 0.18.

Why are the changes needed?

0.18 includes a bug fix for Scala 2.13.

This release fixes a bug (#286) with Scala 2.13.6 in relation with @deprecated annotations in Scala sources leading to a NoSuchElementException in some cases.

https://github.com/lightbend/genjavadoc/releases/tag/v0.18

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Built the doc for Scala 2.13.

build/sbt -Phive -Phive-thriftserver -Pyarn -Pmesos -Pkubernetes -Phadoop-cloud -Pspark-ganglia-lgpl -Pkinesis-asl -Pdocker-integration-tests -Pkubernetes-integration-tests -Pscala-2.13 unidoc

@github-actions github-actions bot added the BUILD label Jul 16, 2021
@dongjoon-hyun
Copy link
Member

GitHub Action Linter and documentation job passed. Merged to master/3.2.

dongjoon-hyun pushed a commit that referenced this pull request Jul 16, 2021
### What changes were proposed in this pull request?

This PR upgrades `GenJavadoc` plugin from `0.17` to `0.18`.

### Why are the changes needed?

`0.18` includes a bug fix for `Scala 2.13`.
```
This release fixes a bug (#286) with Scala 2.13.6 in relation with deprecated annotations in Scala sources leading to a NoSuchElementException in some cases.
```
https://github.com/lightbend/genjavadoc/releases/tag/v0.18

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Built the doc for Scala 2.13.
```
build/sbt -Phive -Phive-thriftserver -Pyarn -Pmesos -Pkubernetes -Phadoop-cloud -Pspark-ganglia-lgpl -Pkinesis-asl -Pdocker-integration-tests -Pkubernetes-integration-tests -Pscala-2.13 unidoc
```

Closes #33383 from sarutak/upgrade-genjavadoc-0.18.

Authored-by: Kousuke Saruta <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
(cherry picked from commit ad744fb)
Signed-off-by: Dongjoon Hyun <[email protected]>
@SparkQA
Copy link

SparkQA commented Jul 16, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45626/

@SparkQA
Copy link

SparkQA commented Jul 16, 2021

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45626/

@SparkQA
Copy link

SparkQA commented Jul 16, 2021

Test build #141113 has finished for PR 33383 at commit 093ac73.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

LuciferYang pushed a commit that referenced this pull request May 15, 2024
### What changes were proposed in this pull request?
This PR upgrades `GenJavadoc` plugin from `0.18` to `0.19`.

### Why are the changes needed?
1.The full release notes: https://github.com/lightbend/genjavadoc/releases/tag/v0.19

2.The latest version supports scala `2.13.14`, which is a `prerequisite` for us to upgrade spark's scala `2.13.14`.
https://mvnrepository.com/artifact/com.typesafe.genjavadoc/genjavadoc-plugin

3.The last upgrade occurred 3 years ago #33383

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Built the doc:

```
./build/sbt -Phadoop-3 -Pkubernetes -Pkinesis-asl -Phive-thriftserver -Pdocker-integration-tests -Pyarn -Phadoop-cloud -Pspark-ganglia-lgpl -Phive -Pjvm-profiler unidoc
```
<img width="501" alt="image" src="https://github.com/apache/spark/assets/15246973/58d3fac8-c968-44e0-83f3-84cf00a5084f">

### Was this patch authored or co-authored using generative AI tooling?
No.

Closes #46579 from panbingkun/unidocGenjavadocVersion_0_19.

Authored-by: panbingkun <[email protected]>
Signed-off-by: yangjie01 <[email protected]>
szehon-ho pushed a commit to szehon-ho/spark that referenced this pull request Aug 7, 2024
### What changes were proposed in this pull request?
This PR upgrades `GenJavadoc` plugin from `0.18` to `0.19`.

### Why are the changes needed?
1.The full release notes: https://github.com/lightbend/genjavadoc/releases/tag/v0.19

2.The latest version supports scala `2.13.14`, which is a `prerequisite` for us to upgrade spark's scala `2.13.14`.
https://mvnrepository.com/artifact/com.typesafe.genjavadoc/genjavadoc-plugin

3.The last upgrade occurred 3 years ago apache#33383

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Built the doc:

```
./build/sbt -Phadoop-3 -Pkubernetes -Pkinesis-asl -Phive-thriftserver -Pdocker-integration-tests -Pyarn -Phadoop-cloud -Pspark-ganglia-lgpl -Phive -Pjvm-profiler unidoc
```
<img width="501" alt="image" src="https://github.com/apache/spark/assets/15246973/58d3fac8-c968-44e0-83f3-84cf00a5084f">

### Was this patch authored or co-authored using generative AI tooling?
No.

Closes apache#46579 from panbingkun/unidocGenjavadocVersion_0_19.

Authored-by: panbingkun <[email protected]>
Signed-off-by: yangjie01 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants