Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-36583][BUILD] Upgrade Apache commons-pool2 from 2.6.2 to 2.11.1 #33831

Closed
wants to merge 1 commit into from

Conversation

LuciferYang
Copy link
Contributor

@LuciferYang LuciferYang commented Aug 25, 2021

What changes were proposed in this pull request?

This pr upgrade Apache commons-pool2 from 2.6.2 to 2.11.1, 2.11.1 is a Java 8 build version and 2.6.2 is still a Java 7 build version.

Why are the changes needed?

Bring some bug fix like DefaultPooledObject.getIdleTime() drops nanoseconds on Java 9 and greater
Other changes: RELEASE-NOTES

Does this PR introduce any user-facing change?

No

How was this patch tested?

Pass the Jenkins or GitHub Action

@github-actions github-actions bot added the BUILD label Aug 25, 2021
@SparkQA
Copy link

SparkQA commented Aug 25, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47260/

@SparkQA
Copy link

SparkQA commented Aug 25, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47260/

@SparkQA
Copy link

SparkQA commented Aug 25, 2021

Test build #142760 has finished for PR 33831 at commit c03bba1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

Can you retrigger https://github.com/LuciferYang/spark/runs/3420201779 please?

@HyukjinKwon
Copy link
Member

cc @HeartSaVioR FYI

@viirya
Copy link
Member

viirya commented Aug 28, 2021

cc @dongjoon-hyun @sunchao

Copy link
Member

@sunchao sunchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (non-binding). Thanks!

@HyukjinKwon
Copy link
Member

Merged to master.

@dongjoon-hyun
Copy link
Member

+1, late LGTM.

@HeartSaVioR
Copy link
Contributor

Late +1, thanks!

@LuciferYang
Copy link
Contributor Author

Thanks all ~

@LuciferYang LuciferYang deleted the commons-pool2 branch October 22, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants