Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC] Fixes formatting typo in SQL programming guide #3498

Closed
wants to merge 1 commit into from
Closed

[DOC] Fixes formatting typo in SQL programming guide #3498

wants to merge 1 commit into from
+0 −2

Conversation

liancheng
Copy link
Contributor

Review on Reviewable

@SparkQA
Copy link

SparkQA commented Nov 27, 2014

Test build #23923 has started for PR 3498 at commit 865ecd7.

  • This patch merges cleanly.

@WangTaoTheTonic
Copy link
Contributor

Sorry but i am curious what is the logo "review on Reviewable"? -___-

@SparkQA
Copy link

SparkQA commented Nov 27, 2014

Test build #23923 has finished for PR 3498 at commit 865ecd7.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23923/
Test PASSed.

@liancheng
Copy link
Contributor Author

@WangTaoTheTonic Reviewable is a tool that makes code review more pleasant :)

@JoshRosen
Copy link
Contributor

LGTM, so I'm going to pull this in. Thanks!

asfgit pushed a commit that referenced this pull request Dec 1, 2014
@liancheng @JoshRosen
[DOC] Fixes formatting typo in SQL programming guide
0f4dad4 
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/apache/spark/3498)
<!-- Reviewable:end -->

Author: Cheng Lian <[email protected]>

Closes #3498 from liancheng/fix-sql-doc-typo and squashes the following commits:

865ecd7 [Cheng Lian] Fixes formatting typo in SQL programming guide

(cherry picked from commit 2a4d389)
Signed-off-by: Josh Rosen <[email protected]>
@asfgit asfgit closed this in 2a4d389 Dec 1, 2014
asfgit pushed a commit that referenced this pull request Dec 1, 2014
@liancheng @JoshRosen
[DOC] Fixes formatting typo in SQL programming guide
91eadd2 
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/apache/spark/3498)
<!-- Reviewable:end -->

Author: Cheng Lian <[email protected]>

Closes #3498 from liancheng/fix-sql-doc-typo and squashes the following commits:

865ecd7 [Cheng Lian] Fixes formatting typo in SQL programming guide

(cherry picked from commit 2a4d389)
Signed-off-by: Josh Rosen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@liancheng @SparkQA @WangTaoTheTonic @AmplabJenkins @JoshRosen