Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-38279][TESTS][3.2] Pin MarkupSafe to 2.0.1 fix linter failure #35602

Closed
wants to merge 1 commit into from

Conversation

itholic
Copy link
Contributor

@itholic itholic commented Feb 22, 2022

What changes were proposed in this pull request?

This PR proposes to pin the Python package markupsafe to 2.0.1 to fix the CI failure as below.

ImportError: cannot import name 'soft_unicode' from 'markupsafe' (/home/runner/work/_temp/setup-sam-43osIE/.venv/lib/python3.10/site-packages/markupsafe/__init__.py)

Since markupsafe==2.1.0 has removed soft_unicode, from markupsafe import soft_unicode no longer working properly.

See aws/aws-sam-cli#3661 for more detail.

Why are the changes needed?

To fix the CI failure on branch-3.2

Does this PR introduce any user-facing change?

No.

How was this patch tested?

The existing tests are should be passed

@HyukjinKwon
Copy link
Member

I think we should better fix it in all branches to reduce conflicts at least, and it's a potential issue in any event. I will forward port this later when I merge.

HyukjinKwon pushed a commit that referenced this pull request Feb 22, 2022
### What changes were proposed in this pull request?

This PR proposes to pin the Python package `markupsafe` to 2.0.1 to fix the CI failure as below.

```
ImportError: cannot import name 'soft_unicode' from 'markupsafe' (/home/runner/work/_temp/setup-sam-43osIE/.venv/lib/python3.10/site-packages/markupsafe/__init__.py)
```

Since `markupsafe==2.1.0` has removed `soft_unicode`, `from markupsafe import soft_unicode` no longer working properly.

See aws/aws-sam-cli#3661 for more detail.

### Why are the changes needed?

To fix the CI failure on branch-3.2

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

The existing tests are should be passed

Closes #35602 from itholic/SPARK-38279.

Authored-by: itholic <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
HyukjinKwon pushed a commit that referenced this pull request Feb 22, 2022
This PR proposes to pin the Python package `markupsafe` to 2.0.1 to fix the CI failure as below.

```
ImportError: cannot import name 'soft_unicode' from 'markupsafe' (/home/runner/work/_temp/setup-sam-43osIE/.venv/lib/python3.10/site-packages/markupsafe/__init__.py)
```

Since `markupsafe==2.1.0` has removed `soft_unicode`, `from markupsafe import soft_unicode` no longer working properly.

See aws/aws-sam-cli#3661 for more detail.

To fix the CI failure on branch-3.2

No.

The existing tests are should be passed

Closes #35602 from itholic/SPARK-38279.

Authored-by: itholic <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
(cherry picked from commit 79099cf)
Signed-off-by: Hyukjin Kwon <[email protected]>
HyukjinKwon pushed a commit that referenced this pull request Feb 22, 2022
This PR proposes to pin the Python package `markupsafe` to 2.0.1 to fix the CI failure as below.

```
ImportError: cannot import name 'soft_unicode' from 'markupsafe' (/home/runner/work/_temp/setup-sam-43osIE/.venv/lib/python3.10/site-packages/markupsafe/__init__.py)
```

Since `markupsafe==2.1.0` has removed `soft_unicode`, `from markupsafe import soft_unicode` no longer working properly.

See aws/aws-sam-cli#3661 for more detail.

To fix the CI failure on branch-3.2

No.

The existing tests are should be passed

Closes #35602 from itholic/SPARK-38279.

Authored-by: itholic <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
(cherry picked from commit 79099cf)
Signed-off-by: Hyukjin Kwon <[email protected]>
@HyukjinKwon
Copy link
Member

Merged to master, branch-3.2, branch-3.1 and branch-3.0.

kazuyukitanimura pushed a commit to kazuyukitanimura/spark that referenced this pull request Aug 10, 2022
### What changes were proposed in this pull request?

This PR proposes to pin the Python package `markupsafe` to 2.0.1 to fix the CI failure as below.

```
ImportError: cannot import name 'soft_unicode' from 'markupsafe' (/home/runner/work/_temp/setup-sam-43osIE/.venv/lib/python3.10/site-packages/markupsafe/__init__.py)
```

Since `markupsafe==2.1.0` has removed `soft_unicode`, `from markupsafe import soft_unicode` no longer working properly.

See aws/aws-sam-cli#3661 for more detail.

### Why are the changes needed?

To fix the CI failure on branch-3.2

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

The existing tests are should be passed

Closes apache#35602 from itholic/SPARK-38279.

Authored-by: itholic <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
@itholic itholic deleted the SPARK-38279 branch April 22, 2023 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants