Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-4296][SQL] Trims aliases when resolving and checking aggregate expressions #4010

Closed
wants to merge 5 commits into from
Closed

[SPARK-4296][SQL] Trims aliases when resolving and checking aggregate expressions #4010

wants to merge 5 commits into from

Conversation

yhuai
Copy link
Contributor

@yhuai yhuai commented Jan 12, 2015

I believe that SPARK-4296 has been fixed by 3684fd2. I am adding tests based #3910 (change the udf to HiveUDF instead).

@SparkQA
Copy link

SparkQA commented Jan 12, 2015

Test build #25430 has started for PR 4010 at commit 6042328.

  • This patch merges cleanly.

@yhuai yhuai changed the title [SPARK-4296][SQL] Trims aliases when resolving and checking aggregate expressions [WIP][SPARK-4296][SQL] Trims aliases when resolving and checking aggregate expressions Jan 12, 2015
@yhuai yhuai changed the title [WIP][SPARK-4296][SQL] Trims aliases when resolving and checking aggregate expressions [SPARK-4296][SQL] Trims aliases when resolving and checking aggregate expressions Jan 12, 2015
@SparkQA
Copy link

SparkQA commented Jan 12, 2015

Test build #25431 has started for PR 4010 at commit 6cfadd2.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Jan 12, 2015

Test build #25430 has finished for PR 4010 at commit 6042328.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25430/
Test FAILed.

@SparkQA
Copy link

SparkQA commented Jan 12, 2015

Test build #25431 has finished for PR 4010 at commit 6cfadd2.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25431/
Test PASSed.

@liancheng liancheng mentioned this pull request Jan 13, 2015
Closed
@liancheng
Copy link
Contributor

LGTM, thanks for pointing out 3684fd2 fixes this!

@yhuai
Merge remote-tracking branch 'upstream/master' into SPARK-4296-yin
6343800 
Conflicts:
	sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
@SparkQA
Copy link

SparkQA commented Jan 21, 2015

Test build #25874 has started for PR 4010 at commit 6343800.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Jan 21, 2015

Test build #25874 has finished for PR 4010 at commit 6343800.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25874/
Test PASSed.

@marmbrus
Copy link
Contributor

Thanks! Merged to master.

@asfgit asfgit closed this in c00d517 Jan 29, 2015
@yhuai yhuai deleted the SPARK-4296-yin branch February 11, 2015 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yhuai @SparkQA @AmplabJenkins @liancheng @marmbrus