[SPARK-44257][BUILD] Update some maven plugins & scalafmt to newest version #41803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panbingkun
commented
Jun 30, 2023
| @@ -535,7 +535,7 @@ class Dataset[T] private[sql] ( | |||
| assert(result.schema.size == 1) | |||
| // scalastyle:off println | |||
| println(result.toArray.head) | |||
| // scalastyle:on println | |||
| // scalastyle:on println | |||
There was a problem hiding this comment.
the newest of the scalafmt identified this issue
yaooqinn
approved these changes
Jun 30, 2023
|
Merged to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr aims to update some maven plugins & scalafmt to newest version, include:
Why are the changes needed?
1.maven-clean-plugin
https://github.com/apache/maven-clean-plugin/releases/tag/maven-clean-plugin-3.3.1
2.maven-shade-plugin
https://github.com/apache/maven-shade-plugin/releases/tag/maven-shade-plugin-3.5.0
3.scalafmt
https://github.com/scalameta/scalafmt/releases/tag/v3.7.5
Router: make sure to indent comments after lambda (scalameta/scalafmt#3556) @kitbellew
Fix proposed version syntax (scalameta/scalafmt#3555) @JD557
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA.