Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-44263][CONNECT] Custom Interceptors Support #41880
[SPARK-44263][CONNECT] Custom Interceptors Support #41880
Changes from 3 commits
38166e9
724cceb
ba78f84
8a983c5
1d4c4c6
5829b74
7102646
8e4997d
d19aae8
4d48e2a
887ea59
2fc8138
e609b8a
475a217
91d880e
8bf8af4
5475873
5c62a4b
ed93d22
92a511e
e730d50
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doc please :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the public facing part of the interface and needs the most extensive documentation,.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, good point :). I didn't do it because other public methods here are undocumented, but that's probably not a good idea either
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This API is no longer unstable (was stabilized) so this can be removed. See grpc/grpc-java#1914
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
client()
method isprivate[sql]
for anyone providing any kinds of wrappers on top of the SparkSession for custom auth integrations it's not possible to use this method.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The proposed usage is rather
SparkSession.builder().interceptor(my interceptor).create()
, and this one is public.Perhaps I should add a test doing this exact line nearby
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now there is an external api test as well (in SparkSessionSuite)