Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-44327][SQL][CONNECT] Add functions any and len to Scala #41886

Closed

Conversation

zhengruifeng
Copy link
Contributor

What changes were proposed in this pull request?

Add functions any and len to Scala API and Spark Connect Scala Client

Why are the changes needed?

they were ignored in previous PRs since they are keyword or built-in function in Python Side, but we can still add them to Scala.

We already have some scala-specific functions, like not

Does this PR introduce any user-facing change?

yes

How was this patch tested?

added UT

Copy link
Contributor

@LuciferYang LuciferYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@zhengruifeng
Copy link
Contributor Author

merged into master, thank you all!

@zhengruifeng zhengruifeng deleted the scala_dedicated_functions branch July 7, 2023 07:20
ragnarok56 pushed a commit to ragnarok56/spark that referenced this pull request Mar 2, 2024
### What changes were proposed in this pull request?
Add functions `any` and `len` to Scala API and Spark Connect Scala Client

### Why are the changes needed?
they were ignored in previous PRs since they are keyword or built-in function in Python Side, but we can still add them to Scala.

We already have some scala-specific functions, like `not`

### Does this PR introduce _any_ user-facing change?
yes

### How was this patch tested?
added UT

Closes apache#41886 from zhengruifeng/scala_dedicated_functions.

Authored-by: Ruifeng Zheng <[email protected]>
Signed-off-by: Ruifeng Zheng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants