-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-44421][FOLLOWUP] Fix doc test in SparkThrowableSuite #42263
[SPARK-44421][FOLLOWUP] Fix doc test in SparkThrowableSuite #42263
Conversation
https://github.com/juliuszsompolski/apache-spark/actions/runs/5726204396/job/15516207448 seems SparkThrowableSuite still test fail |
@LuciferYang yeah... but locally I get... Let me take a closer look... |
CI has:
Strange that a part of Apache License seems to be pulled in into this diff? |
Aaaaah.... so I regenerated the docs, but then forgot to git add the new file it generated. |
Merged to master and branch-3.5. |
### What changes were proposed in this pull request? Forgot to `git add` the file after regenerating docs. ### Why are the changes needed? Fix docs and reenable test. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manually testing SparkThrowableSuite works in both master and branch-3.5. Closes #42263 from juliuszsompolski/SPARK-44421-SparkThrowableSuite-followup. Authored-by: Juliusz Sompolski <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]> (cherry picked from commit 5b8eaf8) Signed-off-by: Hyukjin Kwon <[email protected]>
late LGTM :) |
### What changes were proposed in this pull request? Forgot to `git add` the file after regenerating docs. ### Why are the changes needed? Fix docs and reenable test. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manually testing SparkThrowableSuite works in both master and branch-3.5. Closes apache#42263 from juliuszsompolski/SPARK-44421-SparkThrowableSuite-followup. Authored-by: Juliusz Sompolski <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
What changes were proposed in this pull request?
Forgot to
git add
the file after regenerating docs.Why are the changes needed?
Fix docs and reenable test.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manually testing SparkThrowableSuite works in both master and branch-3.5.