[MINOR][SQL] Remove Scalac 2.12-specific code in InMemoryFileIndex
#43233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
changed the title
InMemoryFileIndex
|
Could you review this, @LuciferYang ? |
|
Merged into master. Thanks @dongjoon-hyun |
|
Thank you, @LuciferYang . |
LuciferYang
pushed a commit
to LuciferYang/spark
that referenced
this pull request
Oct 7, 2023
### What changes were proposed in this pull request? This PR aims to remove `scalac 2.12`-specific code from InMemoryFileIndex class. ### Why are the changes needed? Like the comment mentioned, we don't need this because `master` branch is using Scala 2.13 only. https://github.com/apache/spark/blob/c0d9ca3be14cb0ec8d8f9920d3ecc4aac3cf5adc/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/InMemoryFileIndex.scala#L129 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#43233 from dongjoon-hyun/minor_scalac_2.12. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: yangjie01 <[email protected]>
szehon-ho
pushed a commit
to szehon-ho/spark
that referenced
this pull request
Aug 7, 2024
### What changes were proposed in this pull request? This PR aims to remove `scalac 2.12`-specific code from InMemoryFileIndex class. ### Why are the changes needed? Like the comment mentioned, we don't need this because `master` branch is using Scala 2.13 only. https://github.com/apache/spark/blob/c0d9ca3be14cb0ec8d8f9920d3ecc4aac3cf5adc/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/InMemoryFileIndex.scala#L129 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#43233 from dongjoon-hyun/minor_scalac_2.12. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: yangjie01 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to remove
scalac 2.12-specific code from InMemoryFileIndex class.Why are the changes needed?
Like the comment mentioned, we don't need this because
masterbranch is using Scala 2.13 only.spark/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/InMemoryFileIndex.scala
Line 129 in c0d9ca3
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.