Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-5520][MLlib] Make FP-Growth implementation take generic item types (WIP) #4340

Closed
wants to merge 5 commits into from

Conversation

jackylk
Copy link
Contributor

@jackylk jackylk commented Feb 3, 2015

Make FPGrowth.run API take generic item types:
def run[Item: ClassTag, Basket <: Iterable[Item]](data: RDD[Basket]): FPGrowthModel[Item]
so that user can invoke it by run[String, Seq[String]], run[Int, Seq[Int]], run[Int, List[Int]], etc.

Scala part is done, while java part is still in progress

@SparkQA
Copy link

SparkQA commented Feb 3, 2015

Test build #26656 has started for PR 4340 at commit 793f85c.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Feb 3, 2015

Test build #26656 has finished for PR 4340 at commit 793f85c.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26656/
Test FAILed.

@SparkQA
Copy link

SparkQA commented Feb 3, 2015

Test build #26657 has started for PR 4340 at commit 737d8bb.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Feb 3, 2015

Test build #26657 has finished for PR 4340 at commit 737d8bb.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class FPGrowthModel[Item](val freqItemsets: RDD[(Array[Item], Long)]) extends Serializable

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26657/
Test PASSed.

@mengxr
Copy link
Contributor

mengxr commented Feb 3, 2015

@jackylk I sent you a PR update for Java at: jackylk#2

update to make generic FPGrowth Java-friendly
@SparkQA
Copy link

SparkQA commented Feb 3, 2015

Test build #26689 has started for PR 4340 at commit f5acf84.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Feb 4, 2015

Test build #26689 has finished for PR 4340 at commit f5acf84.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class FPGrowthModel[Item: ClassTag](

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26689/
Test PASSed.

@mengxr
Copy link
Contributor

mengxr commented Feb 4, 2015

LGTM. Merged into master and branch-1.3. Thanks!

asfgit pushed a commit that referenced this pull request Feb 4, 2015
…ypes (WIP)

Make FPGrowth.run API take generic item types:
`def run[Item: ClassTag, Basket <: Iterable[Item]](data: RDD[Basket]): FPGrowthModel[Item]`
so that user can invoke it by run[String, Seq[String]], run[Int, Seq[Int]], run[Int, List[Int]], etc.

Scala part is done, while java part is still in progress

Author: Jacky Li <[email protected]>
Author: Jacky Li <[email protected]>
Author: Xiangrui Meng <[email protected]>

Closes #4340 from jackylk/SPARK-5520-WIP and squashes the following commits:

f5acf84 [Jacky Li] Merge pull request #2 from mengxr/SPARK-5520
63073d0 [Xiangrui Meng] update to make generic FPGrowth Java-friendly
737d8bb [Jacky Li] fix scalastyle
793f85c [Jacky Li] add Java test case
7783351 [Jacky Li] add generic support in FPGrowth

(cherry picked from commit e380d2d)
Signed-off-by: Xiangrui Meng <[email protected]>
@asfgit asfgit closed this in e380d2d Feb 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants