Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-38723][SS][TESTS] Add test for streaming query resume race condition #43405

Closed
wants to merge 1 commit into from

Conversation

PhilDakin
Copy link
Contributor

@PhilDakin PhilDakin commented Oct 17, 2023

What changes were proposed in this pull request?

Add a test for the CONCURRENT_QUERY error raised when multiple sessions try to simultaneously resume the same streaming query from checkpoint.

Why are the changes needed?

Improve testing coverage per https://issues.apache.org/jira/browse/SPARK-38723.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Change is itself a test - ran locally and confirmed the suite passes.

[info] All tests passed.
[success] Total time: 129 s (02:09), completed Oct 17, 2023, 2:11:34 PM

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the SQL label Oct 17, 2023
@PhilDakin
Copy link
Contributor Author

Build failure is in pyspark tests, looks unrelated.

@MaxGekk will you review this, or is there someone else to tag?

@MaxGekk MaxGekk changed the title [SPARK-38723][CORE][STREAMING][TESTS] Add test for streaming query resume race condition. [SPARK-38723][SQL][STREAMING][TESTS] Add test for streaming query resume race condition. Oct 24, 2023
@MaxGekk
Copy link
Member

MaxGekk commented Oct 24, 2023

@HeartSaVioR Could you take a look at the PR, please.

@HeartSaVioR HeartSaVioR changed the title [SPARK-38723][SQL][STREAMING][TESTS] Add test for streaming query resume race condition. [SPARK-38723][SS][TESTS] Add test for streaming query resume race condition Oct 26, 2023
@HeartSaVioR
Copy link
Contributor

I see the test failure is not related. Thanks! Merging to master.

@HeartSaVioR
Copy link
Contributor

@PhilDakin Could you please let me know about your ASF JIRA account? It is needed to recognize your effort in ASF JIRA. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants