[SPARK-47045][SQL] Replace IllegalArgumentException by SparkIllegalArgumentException in sql/api
#45098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
changed the title
IllegalArgumentException by SparkIllegalArgumentException in sql/apiIllegalArgumentException by SparkIllegalArgumentException in sql/api
|
@HyukjinKwon @LuciferYang @panbingkun @srielau @hvanhovell @beliefer Could you review this PR, please. |
| }, | ||
| "_LEGACY_ERROR_TEMP_3257" : { | ||
| "message" : [ | ||
| "All week-based patterns are unsupported since Spark 3.0, detected: <c>, Please use the SQL function EXTRACT instead" |
There was a problem hiding this comment.
nit: punctuation in detected: <c>, Please could be improved, feel free to ignore though :)
There was a problem hiding this comment.
I preserved punctuation of the original error intentionally:
https://github.com/apache/spark/pull/45098/files#diff-1ada8897c412e27c3f73c8f5449f62f1fdc805b979cc7cfa35fcf8ad031529bbL313
to don't break existing tests. We should improve errors while assigning proper error class names, and writing tests for the errors.
srielau
approved these changes
Feb 15, 2024
|
Merging to master. Thank you, @srielau @xinrong-meng for review. |
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose to replace all
IllegalArgumentExceptionbySparkIllegalArgumentExceptioninsql/apicode base, and introduce new legacy error classes with the_LEGACY_ERROR_TEMP_prefix.Why are the changes needed?
To unify Spark SQL exception, and port Java exceptions on Spark exceptions with error classes.
Does this PR introduce any user-facing change?
Yes, it can if user's code assumes some particular format of
IllegalArgumentExceptionmessages.How was this patch tested?
By running existing test suites like:
Was this patch authored or co-authored using generative AI tooling?
No.