[SPARK-47379][TESTS] Improve docker JDBC suite test reliability #45518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaooqinn
reviewed
Mar 14, 2024
| logError(s"Failed to initialize Docker container for ${this.getClass.getName}", e) | ||
| container = createContainerCmd.exec() | ||
| // Start the container and wait until the database can accept JDBC connections: | ||
| docker.startContainerCmd(container.getId).exec() |
There was a problem hiding this comment.
Due to limited GHA resources, it is not advisable to repeatedly start containers.
|
If this is mainly about OracleIntegrationSuite failures, I suggest we use SYS instead of SYSTEM as the connection user. Based on my observation, an Oracle db container fails to be connected for a consistent reason of |
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In this PR I propose changes in Docker JDBC suite with helper function for test retry and better error handling.
Why are the changes needed?
This changes improve general reliability of docker tests that fail at certain workloads.
Does this PR introduce any user-facing change?
No
How was this patch tested?
This is patch for tests.
Was this patch authored or co-authored using generative AI tooling?
No