-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-48137][INFRA] Run yarn
test only in PR builders and Daily CIs
#46395
Conversation
yarn
test only in PR builders and Maven Daily CIsyarn
test only in PR builders and Daily CIs
92fd00c
to
7b81deb
Compare
WDYT, @HyukjinKwon ? |
Alternatively, we can ignore |
Could you review this PR too, @LuciferYang ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you so much! Merged to master~ |
@@ -80,12 +80,14 @@ jobs: | |||
pyspark=`./dev/is-changed.py -m $pyspark_modules` | |||
if [[ "${{ github.repository }}" != 'apache/spark' ]]; then | |||
pandas=$pyspark | |||
yarn=`./dev/is-changed.py -m yarn` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I just reviewed modules.py
and have a small question: if the common/network-yarn
module has changed, should yarn
also be set to true?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, source_file_regexes
has common/network-yarn
and I believe it makes sense.
spark/dev/sparktestsupport/modules.py
Lines 1447 to 1460 in 7c728b2
yarn = Module( | |
name="yarn", | |
dependencies=[], | |
source_file_regexes=[ | |
"resource-managers/yarn/", | |
"common/network-yarn/", | |
], | |
build_profile_flags=["-Pyarn"], | |
sbt_test_goals=[ | |
"yarn/test", | |
"network-yarn/test", | |
], | |
test_tags=["org.apache.spark.tags.ExtendedYarnTest"], | |
) |
### What changes were proposed in this pull request? This PR aims to merge connect back to the original test pipeline to reduce the maximum concurrency of GitHub Action by one. - https://infra.apache.org/github-actions-policy.html > All workflows SHOULD have a job concurrency level less than or equal to 15. ### Why are the changes needed? This is a partial recover from the following. - #45107 We stabilized the root cause of #45107 via the following PRs. In addition we will disable a flaky test case if exists. - #46395 - #46396 - #46425 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #46441 from dongjoon-hyun/SPARK-48174. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
### What changes were proposed in this pull request? We have been providing a dedicated test environment for `yarn` and `connect` module because they are flaky. - apache#45107 However, they are still flaky. So, this PR aims to run `yarn` test only in PR builders (if needed) and Daily CIs (always). - Reduce the irrelevant re-tries by triggering `YARN CI` only when we need to test `YARN` module. - Protect YARN CI from `connect` flakiness by providing an independent GitHub Action environment in PR Builders and Daily CIs. - Lastly, commit builder will offload YARN module tests to the daily CIs ### Why are the changes needed? - PR builders provide an extensive test coverage with YARN testing. - Daily CIs with YARN tests - NON-ANSI CI: https://github.com/apache/spark/actions/workflows/build_non_ansi.yml (1AM) - Java 21 SBT CI: https://github.com/apache/spark/actions/workflows/build_java21.yml (4AM) - RockDB UI CI: https://github.com/apache/spark/actions/workflows/build_rockdb_as_ui_backend.yml (6AM) - Maven Java 17 CI: https://github.com/apache/spark/actions/workflows/build_maven.yml (1PM) - Maven Java 21 CI: https://github.com/apache/spark/actions/workflows/build_maven_java21.yml (2PM) - Maven Java 21 on AppleSilicon CI: https://github.com/apache/spark/actions/workflows/build_maven_java21_macos14.yml (8PM every two days) - YARN CI has been flaky in GitHub Action environment and requires irrelevant re-tries very frequently. - https://github.com/apache/spark/actions/runs/8962451417/job/24611353908 (2024-05-05) - https://github.com/apache/spark/actions/runs/8962440192/job/24611326971 (2024-05-05) ``` [info] *** 6 TESTS FAILED *** [error] Failed tests: [error] org.apache.spark.deploy.yarn.YarnClusterSuite [error] (yarn / Test / test) sbt.TestsFailedException: Tests unsuccessful ``` <img width="544" alt="Screenshot 2024-05-05 at 20 12 28" src="https://github.com/apache/spark/assets/9700541/cbf9fb03-fc4c-4513-b5e5-158c3c9a085a"> ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manual review. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#46395 from dongjoon-hyun/SPARK-48137. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
### What changes were proposed in this pull request? This PR aims to merge connect back to the original test pipeline to reduce the maximum concurrency of GitHub Action by one. - https://infra.apache.org/github-actions-policy.html > All workflows SHOULD have a job concurrency level less than or equal to 15. ### Why are the changes needed? This is a partial recover from the following. - apache#45107 We stabilized the root cause of apache#45107 via the following PRs. In addition we will disable a flaky test case if exists. - apache#46395 - apache#46396 - apache#46425 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#46441 from dongjoon-hyun/SPARK-48174. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
What changes were proposed in this pull request?
We have been providing a dedicated test environment for
yarn
andconnect
module because they are flaky.yarn
andconnect
#45107However, they are still flaky. So, this PR aims to run
yarn
test only in PR builders (if needed) and Daily CIs (always).YARN CI
only when we need to testYARN
module.connect
flakiness by providing an independent GitHub Action environment in PR Builders and Daily CIs.Why are the changes needed?
PR builders provide an extensive test coverage with YARN testing.
Daily CIs with YARN tests
YARN CI has been flaky in GitHub Action environment and requires irrelevant re-tries very frequently.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manual review.
Was this patch authored or co-authored using generative AI tooling?
No.