[SPARK-48569][SS][CONNECT] Handle edge cases in query.name #46920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
reviewed
Jun 10, 2024
| @@ -446,6 +446,11 @@ def partitionBy(self, *cols: str) -> "DataStreamWriter": # type: ignore[misc] | |||
| partitionBy.__doc__ = PySparkDataStreamWriter.partitionBy.__doc__ | |||
|
|
|||
| def queryName(self, queryName: str) -> "DataStreamWriter": | |||
| if not queryName or type(queryName) != str or len(queryName.strip()) == 0: | |||
There was a problem hiding this comment.
should probably use not isinstance(queryName, str)
There was a problem hiding this comment.
Ah, i see. it's consistent with spark classic. okie lgtm
HyukjinKwon
approved these changes
Jun 10, 2024
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Edge case handling.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Added unit test.
Was this patch authored or co-authored using generative AI tooling?
No.