[SPARK-48490][CORE][FOLLOWUP] Properly process escape sequences #47050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @panbingkun |
|
+1, LGTM. |
|
Wait, there may still be some minor issues. Let me verify them in UT. |
panbingkun
reviewed
Jun 21, 2024
panbingkun
suggested changes
Jun 21, 2024
panbingkun
approved these changes
Jun 21, 2024
|
@HyukjinKwon Can we merge this? |
|
Thanks @yaooqinn |
gengliangwang
pushed a commit
that referenced
this pull request
Jun 21, 2024
…s scene ### What changes were proposed in this pull request? The pr is followup #47050 ### Why are the changes needed? Add some UT for the Windows paths scene. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #47051 from panbingkun/SPARK-48490_FOLLOWUP_TESTS. Authored-by: panbingkun <[email protected]> Signed-off-by: Gengliang Wang <[email protected]>
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Oct 4, 2024
### What changes were proposed in this pull request? Even with the fix in apache#46824, the escape sequences (`\r`, `\n`, `\t`, etc) are not handled properly. For example, when we use `log"\n"`, the StringContext interprets `\n` as a literal backslash `\` followed by `n` instead of a newline character. As a result, the bytes of `log"\n".message` becomes `[92, 110]`, instead of `[10]`. This PR is to fix the issue by using the method StringContext.processEscapes in `LogStringContext`. ### Why are the changes needed? To ensure that escape sequences are properly processed in Spark logs ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? New UT ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#47050 from gengliangwang/fixEscape. Authored-by: Gengliang Wang <[email protected]> Signed-off-by: Kent Yao <[email protected]>
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Oct 4, 2024
…s scene ### What changes were proposed in this pull request? The pr is followup apache#47050 ### Why are the changes needed? Add some UT for the Windows paths scene. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#47051 from panbingkun/SPARK-48490_FOLLOWUP_TESTS. Authored-by: panbingkun <[email protected]> Signed-off-by: Gengliang Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Even with the fix in #46824, the escape sequences (
\r,\n,\t, etc) are not handled properly. For example, when we uselog"\n", the StringContext interprets\nas a literal backslash\followed byninstead of a newline character. As a result, the bytes oflog"\n".messagebecomes[92, 110], instead of[10].This PR is to fix the issue by using the method StringContext.processEscapes in
LogStringContext.Why are the changes needed?
To ensure that escape sequences are properly processed in Spark logs
Does this PR introduce any user-facing change?
No
How was this patch tested?
New UT
Was this patch authored or co-authored using generative AI tooling?
No