[SPARK-48911][SQL][FOLLOWUP][TESTS] Fix test for collect_set #47644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
approved these changes
Aug 7, 2024
|
Merged to master. |
uros-db
commented
Aug 7, 2024
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Oct 4, 2024
### What changes were proposed in this pull request? Fix test for `collect_set`. ### Why are the changes needed? `collect_set` doesn't guarantee ordering, so we shouldn't assume it in the test. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Updated test. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#47644 from uros-db/add-tests-followup. Authored-by: Uros Bojanic <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix test for
collect_set.Why are the changes needed?
collect_setdoesn't guarantee ordering, so we shouldn't assume it in the test.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Updated test.
Was this patch authored or co-authored using generative AI tooling?
No.