[SPARK-49205][SQL] KeyGroupedPartitioning should inherit HashPartitioningLike #47734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @yaooqinn @cloud-fan @viirya @sunchao thank you |
yaooqinn
approved these changes
Aug 13, 2024
|
Merged to master. Thank you @ulysses-you @sunchao |
There was a problem hiding this comment.
+1, late LGTM.
BTW, KeyGroupedPartitioning was added at Apache Spark 3.3.0 via SPARK-37377.
Do we need to backport this to branch-3.5 and branch-3.4, @ulysses-you , @sunchao , @yaooqinn ?
|
@dongjoon-hyun it is not a bug fix so the JIRA only targets 4.0.0. I'm fine to backport it to previous branch if you are are interested in. |
|
Thank you for a quick reply. If this is only an improvement, never mind, @ulysses-you . I was think about the original intention at Spark 3.3.0 PR~ |
IvanK-db
pushed a commit
to IvanK-db/spark
that referenced
this pull request
Sep 20, 2024
…ningLike ### What changes were proposed in this pull request? This pr makes `KeyGroupedPartitioning` inherit `HashPartitioningLike`, so that the `BroadcastHashJoin#expandOutputPartitioning` and `PartitioningPreservingUnaryExecNode` can work with it. ### Why are the changes needed? To make `KeyGroupedPartitioning` support alias aware framework. ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? add test ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#47734 from ulysses-you/SPARK-49205-partitioning. Authored-by: ulysses-you <[email protected]> Signed-off-by: Kent Yao <[email protected]>
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Oct 4, 2024
…ningLike ### What changes were proposed in this pull request? This pr makes `KeyGroupedPartitioning` inherit `HashPartitioningLike`, so that the `BroadcastHashJoin#expandOutputPartitioning` and `PartitioningPreservingUnaryExecNode` can work with it. ### Why are the changes needed? To make `KeyGroupedPartitioning` support alias aware framework. ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? add test ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#47734 from ulysses-you/SPARK-49205-partitioning. Authored-by: ulysses-you <[email protected]> Signed-off-by: Kent Yao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr makes
KeyGroupedPartitioninginheritHashPartitioningLike, so that theBroadcastHashJoin#expandOutputPartitioningandPartitioningPreservingUnaryExecNodecan work with it.Why are the changes needed?
To make
KeyGroupedPartitioningsupport alias aware framework.Does this PR introduce any user-facing change?
no
How was this patch tested?
add test
Was this patch authored or co-authored using generative AI tooling?
no