[SPARK-48994][FOLLOW-UP][VARIANT] Address post-merge comments #47792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
approved these changes
Aug 17, 2024
|
thanks, merging to master! |
|
late LGTM, Thanks @harshmotw-db |
harshmotw-db
changed the title
IvanK-db
pushed a commit
to IvanK-db/spark
that referenced
this pull request
Sep 20, 2024
### What changes were proposed in this pull request? The minor post-merge comments from apache#47473 have been addressed ### Why are the changes needed? Improved code style. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing VariantExpressionSuite passes ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#47792 from harshmotw-db/harshmotw-db/PR_fix. Authored-by: Harsh Motwani <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Oct 4, 2024
### What changes were proposed in this pull request? The minor post-merge comments from apache#47473 have been addressed ### Why are the changes needed? Improved code style. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing VariantExpressionSuite passes ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#47792 from harshmotw-db/harshmotw-db/PR_fix. Authored-by: Harsh Motwani <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The minor post-merge comments from #47473 have been addressed
Why are the changes needed?
Improved code style.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing VariantExpressionSuite passes
Was this patch authored or co-authored using generative AI tooling?
No.