[SPARK-49541][BUILD] Upgrade log4j2 to 2.24.1 #48029
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panbingkun
changed the title
panbingkun
changed the title
|
Upon further analysis, it appears that there are some issues with the method
|
|
try to fix this issue: apache/logging-log4j2#2942 |
Fixed, let's wait 2.24.1 |
|
Testing log4j 2.24.1 #48310 |
|
@panbingkun 2.24.1 should be able to pass the tests(https://github.com/LuciferYang/spark/runs/30898064859). Could you please update the PR, including the PR title and description? We can continue to move forward with this PR. |
panbingkun
changed the title
LuciferYang
approved these changes
Oct 2, 2024
LuciferYang
changed the title
Done. |
|
Merged into master for Spark 4.0. Thanks @panbingkun |
|
+1, LGTM. |
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Oct 4, 2024
### What changes were proposed in this pull request? The pr aims to upgrade log4j2 from `2.22.1` to `2.24.1`. ### Why are the changes needed? - The full release notes: https://github.com/apache/logging-log4j2/releases/tag/rel%2F2.24.1 https://github.com/apache/logging-log4j2/releases/tag/rel%2F2.24.0 https://github.com/apache/logging-log4j2/releases/tag/rel%2F2.23.1 https://github.com/apache/logging-log4j2/releases/tag/rel%2F2.23.0 - The new version contains some bug fixes: Fix regression in JdkMapAdapterStringMap performance. (apache/logging-log4j2#2238) Fix NPE in PatternProcessor for a UNIX_MILLIS pattern (apache/logging-log4j2#2346) Fix that parameterized message formatting throws an exception when there are insufficient number of parameters. It previously simply didn't replace the '{}' sequence. The behavior changed in 2.21.0 and should be restored for backward compatibility. (apache/logging-log4j2#2380) Fix putAll() in the default thread context map implementation (apache/logging-log4j2#2942) ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#48029 from panbingkun/SPARK-49541. Authored-by: panbingkun <[email protected]> Signed-off-by: yangjie01 <[email protected]>
himadripal
pushed a commit
to himadripal/spark
that referenced
this pull request
Oct 19, 2024
### What changes were proposed in this pull request? The pr aims to upgrade log4j2 from `2.22.1` to `2.24.1`. ### Why are the changes needed? - The full release notes: https://github.com/apache/logging-log4j2/releases/tag/rel%2F2.24.1 https://github.com/apache/logging-log4j2/releases/tag/rel%2F2.24.0 https://github.com/apache/logging-log4j2/releases/tag/rel%2F2.23.1 https://github.com/apache/logging-log4j2/releases/tag/rel%2F2.23.0 - The new version contains some bug fixes: Fix regression in JdkMapAdapterStringMap performance. (apache/logging-log4j2#2238) Fix NPE in PatternProcessor for a UNIX_MILLIS pattern (apache/logging-log4j2#2346) Fix that parameterized message formatting throws an exception when there are insufficient number of parameters. It previously simply didn't replace the '{}' sequence. The behavior changed in 2.21.0 and should be restored for backward compatibility. (apache/logging-log4j2#2380) Fix putAll() in the default thread context map implementation (apache/logging-log4j2#2942) ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#48029 from panbingkun/SPARK-49541. Authored-by: panbingkun <[email protected]> Signed-off-by: yangjie01 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr aims to upgrade log4j2 from
2.22.1to2.24.1.Why are the changes needed?
The full release notes:
https://github.com/apache/logging-log4j2/releases/tag/rel%2F2.24.1
https://github.com/apache/logging-log4j2/releases/tag/rel%2F2.24.0
https://github.com/apache/logging-log4j2/releases/tag/rel%2F2.23.1
https://github.com/apache/logging-log4j2/releases/tag/rel%2F2.23.0
The new version contains some bug fixes:
Fix regression in JdkMapAdapterStringMap performance. (Avoid a slow exception catch in JdkMapAdapterStringMap constructor logging-log4j2#2238)
Fix NPE in PatternProcessor for a UNIX_MILLIS pattern (NPE in
PatternProcessorwhen using aUNIX_MILLISdate pattern logging-log4j2#2346)Fix that parameterized message formatting throws an exception when there are insufficient number of parameters. It previously simply
didn't replace the '{}' sequence. The behavior changed in 2.21.0 and should be restored for backward compatibility. (Log messages with partially missing parameters logging-log4j2#2380)
Fix putAll() in the default thread context map implementation (Update
newMap.numEntriesafter copying the old map inUnmodifiableArrayBackedMap#copyAndPutAlllogging-log4j2#2942)Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA.
Was this patch authored or co-authored using generative AI tooling?
No.