Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-6103][Graphx]remove unused class to import in EdgeRDDImpl #4846

Closed
wants to merge 1 commit into from

Conversation

lianhuiwang
Copy link
Contributor

Class TaskContext is unused in EdgeRDDImpl, so we need to remove it from import list.

@SparkQA
Copy link

SparkQA commented Mar 2, 2015

Test build #28154 has started for PR 4846 at commit 31aed64.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Mar 2, 2015

Test build #28154 has finished for PR 4846 at commit 31aed64.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class MatrixFactorizationModel(JavaModelWrapper, Saveable, JavaLoader):
    • class Saveable(object):
    • class Loader(object):
    • class JavaLoader(Loader):
    • java_class = ".".join([java_package, cls.__name__])

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28154/
Test PASSed.

@srowen
Copy link
Member

srowen commented Mar 2, 2015

I don't mean to pick on this, but it's an example: this is a trivial, nonfunctional change. Opening a JIRA, opening a PR, emailing the list twice, asking for review, getting it merged, takes up probably a whole hour of time across the various people involved. There is also a very tiny chance that it causes a merge conflict later which has to be manually resolved.

We are still well over 100% capacity to review and merge changes too, so I want to start pushing back a little on things like this.

I do not think it is worth opening issues this small. Instead consider touching up small issues like this when nearby code is already changing. That said, this seems uncontroversial to merge.

@asfgit asfgit closed this in 49c7a8f Mar 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants