Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-6149] [SQL] [Build] Excludes Guava 15 referenced by jackson-module-scala_2.10 #4890

Closed
wants to merge 2 commits into from
Closed

[SPARK-6149] [SQL] [Build] Excludes Guava 15 referenced by jackson-module-scala_2.10 #4890

wants to merge 2 commits into from

Conversation

liancheng
Copy link
Contributor

This PR excludes Guava 15.0 from the SBT build, to make Spark SQL CLI (bin/spark-sql) work when compiled against Hive 0.12.0.

Review on Reviewable

@liancheng
Copy link
Contributor Author

@pwendell I have verified locally that this fixes the SQL CLI tool with Hive 0.12.0. However, I'm not sure whether this is the most proper/elegant way to do the exclusion. Please help review, thanks!

@SparkQA
Copy link

SparkQA commented Mar 4, 2015

Test build #28265 has started for PR 4890 at commit 282bd2a.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Mar 4, 2015

Test build #28265 has finished for PR 4890 at commit 282bd2a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28265/
Test PASSed.

@pwendell
Copy link
Contributor

pwendell commented Mar 4, 2015

@liancheng can you put this exclusion in the pom.xml file instead of in sbt? If you look there we already have other exclusions.

@liancheng
Copy link
Contributor Author

@pwendell Thanks! Moved to POM.

@SparkQA
Copy link

SparkQA commented Mar 5, 2015

Test build #28274 has started for PR 4890 at commit 91ae9fa.

  • This patch merges cleanly.

@pwendell
Copy link
Contributor

pwendell commented Mar 5, 2015

I'm going to "optimistically" merge this to cut another RC.

asfgit pushed a commit that referenced this pull request Mar 5, 2015
@liancheng @pwendell
[SPARK-6149] [SQL] [Build] Excludes Guava 15 referenced by jackson-mo…
a0aa24a 
…dule-scala_2.10

This PR excludes Guava 15.0 from the SBT build, to make Spark SQL CLI (`bin/spark-sql`) work when compiled against Hive 0.12.0.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/apache/spark/4890)
<!-- Reviewable:end -->

Author: Cheng Lian <[email protected]>

Closes #4890 from liancheng/exclude-guava-15 and squashes the following commits:

91ae9fa [Cheng Lian] Moves Guava 15 exclusion from SBT build to POM
282bd2a [Cheng Lian] Excludes Guava 15 referenced by jackson-module-scala_2.10

(cherry picked from commit 1aa90e3)
Signed-off-by: Patrick Wendell <[email protected]>
@asfgit asfgit closed this in 1aa90e3 Mar 5, 2015
@SparkQA
Copy link

SparkQA commented Mar 5, 2015

Test build #28274 has finished for PR 4890 at commit 91ae9fa.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28274/
Test PASSed.

@liancheng liancheng mentioned this pull request Mar 5, 2015
Closed
@liancheng liancheng deleted the exclude-guava-15 branch April 1, 2015 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liancheng @SparkQA @AmplabJenkins @pwendell