Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-6185][SQL] Deltele repeated TOKEN. "TOK_CREATEFUNCTION" and "TOK_SHOWINDEXES" #4907

Closed
wants to merge 4 commits into from
Closed

[SPARK-6185][SQL] Deltele repeated TOKEN. "TOK_CREATEFUNCTION" and "TOK_SHOWINDEXES" #4907

wants to merge 4 commits into from

Conversation

pzzs
Copy link
Contributor

@pzzs pzzs commented Mar 5, 2015

Line 65 "TOK_SHOWINDEXES"
Line 66 "TOK_SHOWINDEXES"

Line 84 "TOK_CREATEFUNCTION"
Line 106 "TOK_CREATEFUNCTION"

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@chenghao-intel
Copy link
Contributor

ok to test

@chenghao-intel
Copy link
Contributor

Good catch, LGTM.

@adrian-wang
Copy link
Contributor

Maybe we can sort all these tokens in alphabetic order to avoid duplicate.

Line 65  TOK_SHOWINDEXES
Line 66  TOK_SHOWINDEXES
@pzzs pzzs changed the title [SPARK-6185][SQL] Deltele repeated TOKEN. "TOK_CREATEFUNCTION" has existed at Line 84 [SPARK-6185][SQL] Deltele repeated TOKEN. "TOK_CREATEFUNCTION" and "TOK_SHOWINDEXES" Mar 7, 2015
@pzzs
Copy link
Contributor Author

pzzs commented Mar 7, 2015

Anyone could test it? @chenghao-intel @marmbrus

@yhuai
Copy link
Contributor

yhuai commented Mar 9, 2015

ok to test

@SparkQA
Copy link

SparkQA commented Mar 9, 2015

Test build #28381 has started for PR 4907 at commit c0bd3f9.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Mar 9, 2015

Test build #28381 has finished for PR 4907 at commit c0bd3f9.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28381/
Test PASSed.

@pzzs
Copy link
Contributor Author

pzzs commented Mar 11, 2015

@yhuai Could it be merged?

@adrian-wang
Copy link
Contributor

Again, I think we'd better sort these tokens in alphabetic order to avoid further duplicate

@marmbrus
Copy link
Contributor

+1 to sorting.
On Mar 10, 2015 7:26 PM, "Daoyuan Wang" [email protected] wrote:

Again, I think we'd better sort these tokens in alphabetic order to avoid
further duplicate


Reply to this email directly or view it on GitHub
#4907 (comment).

@pzzs
Copy link
Contributor Author

pzzs commented Mar 11, 2015

It is a good idea that to sorting , i will do it @adrian-wang @marmbrus @chenghao-intel

@pzzs
Copy link
Contributor Author

pzzs commented Mar 11, 2015

I hava opened a new pr for sorting these tokens in alphabetic.
#4973 @yhuai @marmbrus

@srowen
Copy link
Member

srowen commented Mar 11, 2015

Mind closing this PR?

@pzzs
Copy link
Contributor Author

pzzs commented Mar 12, 2015

yes i will close it @srowen

@pzzs pzzs closed this Mar 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants