-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-6185][SQL] Deltele repeated TOKEN. "TOK_CREATEFUNCTION" and "TOK_SHOWINDEXES" #4907
Conversation
merge lastest spark
merge lastest spark
Can one of the admins verify this patch? |
ok to test |
Good catch, LGTM. |
Maybe we can sort all these tokens in alphabetic order to avoid duplicate. |
Line 65 TOK_SHOWINDEXES Line 66 TOK_SHOWINDEXES
Anyone could test it? @chenghao-intel @marmbrus |
ok to test |
Test build #28381 has started for PR 4907 at commit
|
Test build #28381 has finished for PR 4907 at commit
|
Test PASSed. |
@yhuai Could it be merged? |
Again, I think we'd better sort these tokens in alphabetic order to avoid further duplicate |
+1 to sorting.
|
It is a good idea that to sorting , i will do it @adrian-wang @marmbrus @chenghao-intel |
Mind closing this PR? |
yes i will close it @srowen |
Line 65 "TOK_SHOWINDEXES"
Line 66 "TOK_SHOWINDEXES"
Line 84 "TOK_CREATEFUNCTION"
Line 106 "TOK_CREATEFUNCTION"