[SPARK-6405] Limiting the maximum Kryo buffer size to be 2GB. #5218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kryo buffers are backed by byte arrays, but primitive arrays can only be up to 2GB in size. It is misleading to allow users to set buffers past this size.
|
Test build #29260 has finished for PR 5218 at commit
|
|
Test build #29262 has finished for PR 5218 at commit
|
| @@ -49,10 +49,20 @@ class KryoSerializer(conf: SparkConf) | |||
| with Logging | |||
| with Serializable { | |||
|
|
|||
| private val bufferSize = | |||
| (conf.getDouble("spark.kryoserializer.buffer.mb", 0.064) * 1024 * 1024).toInt | |||
| private val bufferSizeMb: Double = conf.getDouble("spark.kryoserializer.buffer.mb", 0.064) | |||
There was a problem hiding this comment.
Declaring the type here is more descriptive, but I'd leave it out to be consistent with the other variables in the class.
|
LGTM |
| throw new IllegalArgumentException("spark.kryoserializer.buffer.max.mb must be less than " + | ||
| s"2048 mb, got: + $maxBufferSizeMb mb.") | ||
| } | ||
| private val maxBufferSize = maxBufferSizeMb * 1026 * 1024 |
There was a problem hiding this comment.
Is this meant to be 1026 * 1024?
|
LGTM pending jenkins |
|
Test build #29273 has finished for PR 5218 at commit
|
|
Test build #29277 has finished for PR 5218 at commit
|
|
LGTM - merged into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kryo buffers are backed by byte arrays, but primitive arrays can only be
up to 2GB in size. It is misleading to allow users to set buffers past
this size.