Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-6705][MLLIB] Add fit intercept api to ml logisticregression #5301

Closed
wants to merge 6 commits into from

Commits on Mar 31, 2015

  1. [MLLIB] Add fit intercept api to ml logisticregression

    I have the fit intercept enabled by default for logistic regression, I
    wonder what others think here. I understand that it enables allocation
    by default which is undesirable, but one needs to have a very strong
    reason for not having an intercept term enabled so it is the safer
    default from a statistical sense.
    
    Explicitly modeling the intercept by adding a column of all 1s does not
    work. I believe the reason is that since the API for
    LogisticRegressionWithLBFGS forces column normalization, and a column of all
    1s has 0 variance so dividing by 0 kills it.
    Omede Firouz committed Mar 31, 2015
    Configuration menu
    Copy the full SHA
    bd9663c View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2015

  1. [MLLIB] Add fit intercept term

    Added unit tests and changed docs in line with PR comments
    Omede Firouz committed Apr 3, 2015
    Configuration menu
    Copy the full SHA
    329c1e2 View commit details
    Browse the repository at this point in the history
  2. [MLLIB] Add fitIntercept param to logistic regression

    Made the trait default true
    Changed float comparisons to === in unit tests
    Omede Firouz committed Apr 3, 2015
    Configuration menu
    Copy the full SHA
    2257fca View commit details
    Browse the repository at this point in the history
  3. [MLLIB] Add fitIntercept to LogisticRegression

    Forgot to update doc
    Omede Firouz committed Apr 3, 2015
    Configuration menu
    Copy the full SHA
    9963509 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1d6bd6f View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2015

  1. [SPARK-6705][MLLIB] Add fitInterceptTerm to LogisticRegression

    Whoops, add this to the logisticRegression and not the optimizer
    Omede Firouz committed Apr 4, 2015
    Configuration menu
    Copy the full SHA
    9f1286b View commit details
    Browse the repository at this point in the history