Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-6257] [PySpark] [MLlib] MLlib API missing items in Recommendation #5807

Closed
wants to merge 2 commits into from
Closed

[SPARK-6257] [PySpark] [MLlib] MLlib API missing items in Recommendation #5807

wants to merge 2 commits into from

Conversation

MechCoder
Copy link
Contributor

Adds

rank, recommendUsers and RecommendProducts to MatrixFactorizationModel in PySpark.

@MechCoder
Copy link
Contributor Author

@jkbradley

Does it make sense to have things like "setXXX" in Python especially since the attributes are always accessible and especially in this case since the recommendation is trained using methods of the static object ALS?

@MechCoder
Copy link
Contributor Author

Also the release deadline means that PR's would still be reviewed right? It is just that they would enter the 1.5 branch instead of the 1.4?
Btw, are there are other important issues that have to be tackled for the 1.4 release?

@SparkQA
Copy link

SparkQA commented Apr 30, 2015

Test build #31415 has finished for PR 5807 at commit 5d75c31.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@SparkQA
Copy link

SparkQA commented Apr 30, 2015

Test build #31418 has finished for PR 5807 at commit 2b1dd89.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

mengxr
mengxr reviewed Apr 30, 2015
View reviewed changes
python/pyspark/mllib/recommendation.py
@@ -105,9 +112,15 @@ class MatrixFactorizationModel(JavaModelWrapper, JavaSaveable, JavaLoader):
... pass
"""
def predict(self, user, product):
"""
Predicts rating for a given user and product.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a given user and product pair or the given user and product

@MechCoder
Copy link
Contributor Author

@mengxr fixed!

@SparkQA
Copy link

SparkQA commented May 1, 2015

Test build #31501 has finished for PR 5807 at commit dfc1567.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@SparkQA
Copy link

SparkQA commented May 1, 2015

Test build #31508 has finished for PR 5807 at commit 09629c6.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@mengxr
Copy link
Contributor

mengxr commented May 1, 2015

LGTM. Merged into master. Thanks!

@asfgit asfgit closed this in c24aeb6 May 1, 2015
@MechCoder MechCoder deleted the spark-6257 branch May 1, 2015 06:52
@MechCoder
Copy link
Contributor Author

Thanks for the quick comments and merge. Would you be able to have a look at this (#5775) too?

jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request May 28, 2015
@MechCoder @jeanlyn
[SPARK-6257] [PYSPARK] [MLLIB] MLlib API missing items in Recommendation
3886acf 
Adds

rank, recommendUsers and RecommendProducts to MatrixFactorizationModel in PySpark.

Author: MechCoder <[email protected]>

Closes apache#5807 from MechCoder/spark-6257 and squashes the following commits:

09629c6 [MechCoder] doc
953b326 [MechCoder] [SPARK-6257] MLlib API missing items in Recommendation
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
@MechCoder @jeanlyn
[SPARK-6257] [PYSPARK] [MLLIB] MLlib API missing items in Recommendation
54c7b85 
Adds

rank, recommendUsers and RecommendProducts to MatrixFactorizationModel in PySpark.

Author: MechCoder <[email protected]>

Closes apache#5807 from MechCoder/spark-6257 and squashes the following commits:

09629c6 [MechCoder] doc
953b326 [MechCoder] [SPARK-6257] MLlib API missing items in Recommendation
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
@MechCoder @nemccarthy
[SPARK-6257] [PYSPARK] [MLLIB] MLlib API missing items in Recommendation
bdd9df7 
Adds

rank, recommendUsers and RecommendProducts to MatrixFactorizationModel in PySpark.

Author: MechCoder <[email protected]>

Closes apache#5807 from MechCoder/spark-6257 and squashes the following commits:

09629c6 [MechCoder] doc
953b326 [MechCoder] [SPARK-6257] MLlib API missing items in Recommendation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MechCoder @SparkQA @mengxr