Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-11394][SQL] Throw IllegalArgumentException for unsupported types in postgresql #9350

Closed
wants to merge 2 commits into from
Closed

[SPARK-11394][SQL] Throw IllegalArgumentException for unsupported types in postgresql #9350

wants to merge 2 commits into from

Conversation

maropu
Copy link
Member

@maropu maropu commented Oct 29, 2015

If DataFrame has BYTE types, throws an exception:
org.postgresql.util.PSQLException: ERROR: type "byte" does not exist

@SparkQA
Copy link

SparkQA commented Oct 29, 2015

Test build #44573 has finished for PR 9350 at commit 337eef6.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 21, 2015

Test build #48099 has finished for PR 9350 at commit c2363aa.

  • This patch fails from timeout after a configured wait of 250m.
  • This patch merges cleanly.
  • This patch adds no public classes.

@maropu
Copy link
Member Author

maropu commented Dec 21, 2015

retest this please

@SparkQA
Copy link

SparkQA commented Dec 22, 2015

Test build #48139 has finished for PR 9350 at commit c2363aa.

  • This patch fails from timeout after a configured wait of 250m.
  • This patch merges cleanly.
  • This patch adds no public classes.

@maropu
Copy link
Member Author

maropu commented Dec 24, 2015

retest this please

@SparkQA
Copy link

SparkQA commented Dec 24, 2015

Test build #48292 has finished for PR 9350 at commit c2363aa.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@maropu
Copy link
Member Author

maropu commented Dec 24, 2015

@liancheng @yhuai This is a trivial fix, so could you review this?

@SparkQA
Copy link

SparkQA commented Dec 24, 2015

Test build #2254 has started for PR 9350 at commit c2363aa.

@liancheng
Copy link
Contributor

LGTM pending Jenkins. Thanks!

@yhuai
Copy link
Contributor

yhuai commented Dec 29, 2015

test this please

@yhuai
Copy link
Contributor

yhuai commented Dec 29, 2015

oh, it already passed the tests.

asfgit pushed a commit that referenced this pull request Dec 29, 2015
@maropu @yhuai
[SPARK-11394][SQL] Throw IllegalArgumentException for unsupported typ…
85a8718 
…es in postgresql

If DataFrame has BYTE types, throws an exception:
org.postgresql.util.PSQLException: ERROR: type "byte" does not exist

Author: Takeshi YAMAMURO <[email protected]>

Closes #9350 from maropu/FixBugInPostgreJdbc.

(cherry picked from commit 73862a1)
Signed-off-by: Yin Huai <[email protected]>
@yhuai
Copy link
Contributor

yhuai commented Dec 29, 2015

Merging to branch 1.6 and master. Thank you!

@asfgit asfgit closed this in 73862a1 Dec 29, 2015
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48397/
Test FAILed.

@maropu maropu deleted the FixBugInPostgreJdbc branch July 5, 2017 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@maropu @SparkQA @liancheng @yhuai @AmplabJenkins