fix: Properly update output streams in functions #3238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
java
tenthe
approved these changes
Sep 23, 2024
dominikriemer
added a commit
that referenced
this pull request
Sep 27, 2024
* chore(deps): bump peter-evans/create-pull-request from 6 to 7 (#3215) Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 6 to 7. - [Release notes](https://github.com/peter-evans/create-pull-request/releases) - [Commits](peter-evans/create-pull-request@v6...v7) --- updated-dependencies: - dependency-name: peter-evans/create-pull-request dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(#3247): Add waiting time and add test to smoke tests (#3248) * fix(#3247): Add waiting time and add test to smoke tests * fix(#3247): Fix linting * fix(#3247): Try to remove the loop * fix(#3247): Add timeout to open new data view * fix(#3247): Change opc ua test and rime range test * fix: Properly update output streams in functions (#3238) * fix: Better handle runtime-resolved selections --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Philipp Zehnder <[email protected]>
dominikriemer
added a commit
that referenced
this pull request
Sep 30, 2024
* refactor: Rename domain properties to semantic type * Fix cloning * Fix serialization, remove domain property references * Improve serializer * Fix error * fix: Improve handling of runtime-resolved selections (#3255) * chore(deps): bump peter-evans/create-pull-request from 6 to 7 (#3215) Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 6 to 7. - [Release notes](https://github.com/peter-evans/create-pull-request/releases) - [Commits](peter-evans/create-pull-request@v6...v7) --- updated-dependencies: - dependency-name: peter-evans/create-pull-request dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(#3247): Add waiting time and add test to smoke tests (#3248) * fix(#3247): Add waiting time and add test to smoke tests * fix(#3247): Fix linting * fix(#3247): Try to remove the loop * fix(#3247): Add timeout to open new data view * fix(#3247): Change opc ua test and rime range test * fix: Properly update output streams in functions (#3238) * fix: Better handle runtime-resolved selections --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Philipp Zehnder <[email protected]> * Migrate domainProperties to semantic type for python and go * Update model, add deprecations * Fix checkstyle * Remove obsolete constructor * Cleanup constructor * Rename DomainPropertyMatch * rename variables * Remove console output --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Philipp Zehnder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix a bug which caused an exception if an output data stream of a function is already present. This fix updates any existing output data stream when the function is started.
Remarks
PR introduces (a) breaking change(s): <yes/no>
PR introduces (a) deprecation(s): <yes/no>