Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WW-3714 Deprecate and repackage common APIs part 6 #1085

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Conversation

kusalk
Copy link
Member

@kusalk kusalk commented Oct 17, 2024

WW-3714

This PR deprecates and provides repackaged replacements for the following APIs, ahead of their permanent migration in Struts 7.0:

  • com.opensymphony.xwork2.interceptor.AliasInterceptor
  • com.opensymphony.xwork2.interceptor.ChainingInterceptor
  • com.opensymphony.xwork2.interceptor.ConversionErrorInterceptor
  • com.opensymphony.xwork2.interceptor.DefaultWorkflowInterceptor
  • com.opensymphony.xwork2.interceptor.ExceptionMappingInterceptor
  • com.opensymphony.xwork2.interceptor.LoggingInterceptor
  • com.opensymphony.xwork2.interceptor.ModelDrivenInterceptor
  • com.opensymphony.xwork2.interceptor.ParameterRemoverInterceptor
  • com.opensymphony.xwork2.interceptor.PrepareInterceptor
  • com.opensymphony.xwork2.interceptor.ScopedModelDrivenInterceptor
  • com.opensymphony.xwork2.interceptor.StaticParametersInterceptor

Similar to #1084, the interceptor implementations were necessarily duplicated to ensure complete overriding compatibility with the old interceptor types, whilst allowing the new interceptors to extend the new variants of AbstractInterceptor and MethodFilterInterceptor (as they would be in Struts 7.0).

This PR additional modifies the following abstract class to enable overriding without importing com.opensymphony.xwork2.ActionInvocation:

  • org.apache.struts2.result.StrutsResultSupport

@kusalk kusalk changed the title WW-3714 Deprecate and repackage common APIs part 5 WW-3714 Deprecate and repackage common APIs part 6 Oct 17, 2024
@kusalk kusalk force-pushed the kusal-depr-apis-6 branch 2 times, most recently from f908a32 to 717046f Compare October 17, 2024 08:36
Copy link

sonarcloud bot commented Oct 22, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
20.3% Coverage on New Code (required ≥ 80%)
27.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Base automatically changed from kusal-depr-apis-6 to master October 23, 2024 10:12
@kusalk kusalk merged commit 89bcbec into master Oct 25, 2024
8 of 9 checks passed
@kusalk kusalk deleted the kusal-depr-apis-7 branch October 25, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants