-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WW-3714 Deprecate and repackage common APIs part 6 #1085
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kusalk
changed the title
WW-3714 Deprecate and repackage common APIs part 5
WW-3714 Deprecate and repackage common APIs part 6
Oct 17, 2024
kusalk
force-pushed
the
kusal-depr-apis-7
branch
from
October 17, 2024 08:27
a6c4b52
to
7b212c4
Compare
kusalk
force-pushed
the
kusal-depr-apis-6
branch
2 times, most recently
from
October 17, 2024 08:36
f908a32
to
717046f
Compare
kusalk
force-pushed
the
kusal-depr-apis-7
branch
from
October 17, 2024 08:37
7b212c4
to
1b86f8d
Compare
kusalk
force-pushed
the
kusal-depr-apis-6
branch
from
October 17, 2024 09:10
717046f
to
f8dc1ce
Compare
kusalk
force-pushed
the
kusal-depr-apis-7
branch
from
October 17, 2024 09:10
1b86f8d
to
440153c
Compare
kusalk
force-pushed
the
kusal-depr-apis-6
branch
from
October 17, 2024 09:29
f8dc1ce
to
a874416
Compare
kusalk
force-pushed
the
kusal-depr-apis-7
branch
from
October 17, 2024 09:30
440153c
to
c91e032
Compare
core/src/main/java/org/apache/struts2/result/StrutsResultSupport.java
Dismissed
Show dismissed
Hide dismissed
kusalk
force-pushed
the
kusal-depr-apis-7
branch
from
October 22, 2024 00:32
9e60587
to
8ff8d18
Compare
kusalk
force-pushed
the
kusal-depr-apis-6
branch
from
October 22, 2024 02:56
1032783
to
1dea3d3
Compare
kusalk
force-pushed
the
kusal-depr-apis-7
branch
from
October 22, 2024 02:56
8ff8d18
to
18f85c5
Compare
kusalk
force-pushed
the
kusal-depr-apis-6
branch
from
October 22, 2024 05:55
1dea3d3
to
228d33e
Compare
kusalk
force-pushed
the
kusal-depr-apis-7
branch
from
October 22, 2024 05:56
18f85c5
to
7c664c0
Compare
kusalk
force-pushed
the
kusal-depr-apis-6
branch
from
October 22, 2024 06:02
228d33e
to
deb6c09
Compare
kusalk
force-pushed
the
kusal-depr-apis-7
branch
from
October 22, 2024 06:05
7c664c0
to
cdb7088
Compare
kusalk
force-pushed
the
kusal-depr-apis-7
branch
from
October 22, 2024 07:51
cdb7088
to
2432449
Compare
Quality Gate failedFailed conditions |
lukaszlenart
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WW-3714
This PR deprecates and provides repackaged replacements for the following APIs, ahead of their permanent migration in Struts 7.0:
com.opensymphony.xwork2.interceptor.AliasInterceptor
com.opensymphony.xwork2.interceptor.ChainingInterceptor
com.opensymphony.xwork2.interceptor.ConversionErrorInterceptor
com.opensymphony.xwork2.interceptor.DefaultWorkflowInterceptor
com.opensymphony.xwork2.interceptor.ExceptionMappingInterceptor
com.opensymphony.xwork2.interceptor.LoggingInterceptor
com.opensymphony.xwork2.interceptor.ModelDrivenInterceptor
com.opensymphony.xwork2.interceptor.ParameterRemoverInterceptor
com.opensymphony.xwork2.interceptor.PrepareInterceptor
com.opensymphony.xwork2.interceptor.ScopedModelDrivenInterceptor
com.opensymphony.xwork2.interceptor.StaticParametersInterceptor
Similar to #1084, the interceptor implementations were necessarily duplicated to ensure complete overriding compatibility with the old interceptor types, whilst allowing the new interceptors to extend the new variants of
AbstractInterceptor
andMethodFilterInterceptor
(as they would be in Struts 7.0).This PR additional modifies the following abstract class to enable overriding without importing
com.opensymphony.xwork2.ActionInvocation
:org.apache.struts2.result.StrutsResultSupport