Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WW-5384] Update log4j2 to 2.22.1 and [WW-5393] caffeine to 3.1.8 including error_prone_annotations > 2.10.0 which depends on Java 11 #870

Conversation

sepe81
Copy link
Contributor

@sepe81 sepe81 commented Feb 5, 2024

No description provided.

(cherry picked from commit fd2cf91)
and error_prone_annotations > 2.10.0 which depends on Java 11
@sepe81 sepe81 marked this pull request as draft February 5, 2024 12:55
@sepe81
Copy link
Contributor Author

sepe81 commented Feb 5, 2024

Need to check:

Dependency convergence error for com.google.errorprone:error_prone_annotations:jar:2.23.0:compile paths to dependency are:
+-org.apache.struts:struts2-showcase:war:7.0.0-M3-SNAPSHOT
+-org.apache.logging.log4j:log4j-api:jar:2.22.1:compile
+-com.google.errorprone:error_prone_annotations:jar:2.23.0:compile
and
+-org.apache.struts:struts2-showcase:war:7.0.0-M3-SNAPSHOT
+-org.apache.struts:struts2-core:jar:7.0.0-M3-SNAPSHOT:compile
+-com.github.ben-manes.caffeine:caffeine:jar:2.9.3:compile
+-com.google.errorprone:error_prone_annotations:jar:2.10.0:compile

@sepe81 sepe81 changed the title Update log4j2 to 2.22.1 including error_prone_annotations > 2.10.0 which depends on Java 11 Update log4j2 to 2.22.1 and caffeine to 3.1.8 including error_prone_annotations > 2.10.0 which depends on Java 11 Feb 5, 2024
@@ -633,7 +633,14 @@
<dependency>
<groupId>com.github.ben-manes.caffeine</groupId>
<artifactId>caffeine</artifactId>
<version>2.9.3</version>
<version>3.1.8</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to register a ticket for upgrading this lib and link it here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sepe81 sepe81 force-pushed the feature/update-log42j-for-java-version-after-8 branch from 898091e to d1413b0 Compare February 8, 2024 21:16
@sepe81 sepe81 marked this pull request as ready for review February 8, 2024 21:17
@sepe81 sepe81 changed the title Update log4j2 to 2.22.1 and caffeine to 3.1.8 including error_prone_annotations > 2.10.0 which depends on Java 11 [WW-5384] Update log4j2 to 2.22.1 and [WW-5393] caffeine to 3.1.8 including error_prone_annotations > 2.10.0 which depends on Java 11 Feb 8, 2024
@lukaszlenart lukaszlenart merged commit d384c82 into apache:release/struts-7-0-x Feb 9, 2024
5 checks passed
@sepe81 sepe81 deleted the feature/update-log42j-for-java-version-after-8 branch June 12, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants