Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WW-5310 Fixes broken support for Fragments in <s:url/> tag #968

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

lukaszlenart
Copy link
Member

Closes WW-5310

Copy link

sonarcloud bot commented Jun 18, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
8 Security Hotspots
28.6% Coverage on New Code (required ≥ 80%)
4.0% Duplication on New Code (required ≤ 3%)
E Reliability Rating on New Code (required ≥ A)
E Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link
Member

@rgielen rgielen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've crosschecked https://datatracker.ietf.org/doc/html/rfc3986#section-2.1 to understand whether it's our business to take care of unencoded '=' in value of k/v pair, but it looks like it SHOULD be encoded, but is not required. Splitting at first '=' only seems to be legit and preferred behaviour.

That said, the fix correctly addresses both the improved handling for unencoded '=' as well as proper dealing with the fragment part 👍

@lukaszlenart lukaszlenart merged commit a895450 into master Jun 21, 2024
9 of 10 checks passed
@lukaszlenart lukaszlenart deleted the fix/WW-5310-fragment branch June 21, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants