Skip to content

Commit

Permalink
test: Fix act errors in DndFilterSelect test (#21429)
Browse files Browse the repository at this point in the history
  • Loading branch information
lyndsiWilliams authored Sep 10, 2022
1 parent 2c7da64 commit 210a2b9
Showing 1 changed file with 18 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -48,23 +48,25 @@ const baseFormData = {
datasource: 'table__1',
};

test('renders with default props', () => {
test('renders with default props', async () => {
render(<DndFilterSelect {...defaultProps} />, { useDnd: true });
expect(screen.getByText('Drop columns or metrics here')).toBeInTheDocument();
expect(
await screen.findByText('Drop columns or metrics here'),
).toBeInTheDocument();
});

test('renders with value', () => {
test('renders with value', async () => {
const value = new AdhocFilter({
sqlExpression: 'COUNT(*)',
expressionType: EXPRESSION_TYPES.SQL,
});
render(<DndFilterSelect {...defaultProps} value={[value]} />, {
useDnd: true,
});
expect(screen.getByText('COUNT(*)')).toBeInTheDocument();
expect(await screen.findByText('COUNT(*)')).toBeInTheDocument();
});

test('renders options with saved metric', () => {
test('renders options with saved metric', async () => {
render(
<DndFilterSelect
{...defaultProps}
Expand All @@ -78,10 +80,12 @@ test('renders options with saved metric', () => {
useDnd: true,
},
);
expect(screen.getByText('Drop columns or metrics here')).toBeInTheDocument();
expect(
await screen.findByText('Drop columns or metrics here'),
).toBeInTheDocument();
});

test('renders options with column', () => {
test('renders options with column', async () => {
render(
<DndFilterSelect
{...defaultProps}
Expand All @@ -98,10 +102,12 @@ test('renders options with column', () => {
useDnd: true,
},
);
expect(screen.getByText('Drop columns or metrics here')).toBeInTheDocument();
expect(
await screen.findByText('Drop columns or metrics here'),
).toBeInTheDocument();
});

test('renders options with adhoc metric', () => {
test('renders options with adhoc metric', async () => {
const adhocMetric = new AdhocMetric({
expression: 'AVG(birth_names.num)',
metric_name: 'avg__num',
Expand All @@ -119,5 +125,7 @@ test('renders options with adhoc metric', () => {
useDnd: true,
},
);
expect(screen.getByText('Drop columns or metrics here')).toBeInTheDocument();
expect(
await screen.findByText('Drop columns or metrics here'),
).toBeInTheDocument();
});

0 comments on commit 210a2b9

Please sign in to comment.