fix: Delete modal button with lowercase text (#30060)

(cherry picked from commit cd6b8b2)
apache · Sep 6, 2024 · 4581606 · 4581606
1 parent cea8ede
commit 4581606
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/superset-frontend/src/components/DeleteModal/DeleteModal.test.tsx b/superset-frontend/src/components/DeleteModal/DeleteModal.test.tsx
@@ -77,12 +77,12 @@ test('Calling "onConfirm" only after typing "delete" in the input', () => {
   expect(props.onConfirm).toBeCalledTimes(0);
 
   // do not execute "onConfirm" if you have not typed "delete"
-  userEvent.click(screen.getByText('delete'));
+  userEvent.click(screen.getByText('Delete'));
   expect(props.onConfirm).toBeCalledTimes(0);
 
   // execute "onConfirm" if you have typed "delete"
   userEvent.type(screen.getByTestId('delete-modal-input'), 'delete');
-  userEvent.click(screen.getByText('delete'));
+  userEvent.click(screen.getByText('Delete'));
   expect(props.onConfirm).toBeCalledTimes(1);
 
   // confirm input has been cleared

diff --git a/superset-frontend/src/components/DeleteModal/index.tsx b/superset-frontend/src/components/DeleteModal/index.tsx
@@ -81,7 +81,7 @@ export default function DeleteModal({
       disablePrimaryButton={disableChange}
       onHide={hide}
       onHandledPrimaryAction={confirm}
-      primaryButtonName={t('delete')}
+      primaryButtonName={t('Delete')}
       primaryButtonType="danger"
       show={open}
       title={title}