fix: Published Dashboard without charts don't show up for non admin u…

…sers (#20638)
apache · Jul 27, 2022 · 8b354b4 · 8b354b4
1 parent ab415fd
commit 8b354b4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/superset/dashboards/filters.py b/superset/dashboards/filters.py
@@ -111,7 +111,7 @@ def apply(self, query: Query, value: Any) -> Query:
 
         datasource_perm_query = (
             db.session.query(Dashboard.id)
-            .join(Dashboard.slices)
+            .join(Dashboard.slices, isouter=True)
             .filter(
                 and_(
                     Dashboard.published.is_(True),

diff --git a/superset/sql_parse.py b/superset/sql_parse.py
@@ -494,7 +494,7 @@ class InsertRLSState(str, Enum):
 
 def has_table_query(token_list: TokenList) -> bool:
     """
-    Return if a stament has a query reading from a table.
+    Return if a statement has a query reading from a table.
 
         >>> has_table_query(sqlparse.parse("COUNT(*)")[0])
         False