feat(tags): move tags from navbar to settings (#24518)

Co-authored-by: Daniel Vaz Gaspar <[email protected]>
apache · Jun 28, 2023 · a846e8a · a846e8a
1 parent 7501134
commit a846e8a
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 14 deletions.
diff --git a/superset/charts/commands/warm_up_cache.py b/superset/charts/commands/warm_up_cache.py
@@ -30,7 +30,6 @@
 
 
 class ChartWarmUpCacheCommand(BaseCommand):
-    # pylint: disable=too-many-arguments
     def __init__(
         self,
         chart_or_id: Union[int, Slice],

diff --git a/superset/databases/api.py b/superset/databases/api.py
@@ -383,9 +383,7 @@ def post(self) -> FlaskResponse:
 
             # Return SSH Tunnel and hide passwords if any
             if item.get("ssh_tunnel"):
-                item["ssh_tunnel"] = mask_password_info(
-                    new_model.ssh_tunnel  # pylint: disable=no-member
-                )
+                item["ssh_tunnel"] = mask_password_info(new_model.ssh_tunnel)
 
             return self.response(201, id=new_model.id, result=item)
         except DatabaseInvalidError as ex:

diff --git a/superset/datasets/commands/warm_up_cache.py b/superset/datasets/commands/warm_up_cache.py
@@ -28,7 +28,6 @@
 
 
 class DatasetWarmUpCacheCommand(BaseCommand):
-    # pylint: disable=too-many-arguments
     def __init__(
         self,
         db_name: str,

diff --git a/superset/initialization/__init__.py b/superset/initialization/__init__.py
@@ -156,7 +156,7 @@ def init_views(self) -> None:
         from superset.sqllab.api import SqlLabRestApi
         from superset.tags.api import TagRestApi
         from superset.views.alerts import AlertView, ReportView
-        from superset.views.all_entities import TaggedObjectsModelView, TaggedObjectView
+        from superset.views.all_entities import TaggedObjectView
         from superset.views.annotations import AnnotationLayerView
         from superset.views.api import Api
         from superset.views.chart.views import SliceAsync, SliceModelView
@@ -366,20 +366,13 @@ def init_views(self) -> None:
             category="SQL Lab",
             category_label=__("SQL Lab"),
         )
-        appbuilder.add_view(
-            TaggedObjectsModelView,
-            "All Entities",
-            label=__("All Entities"),
-            icon="",
-            category_icon="",
-            menu_cond=lambda: feature_flag_manager.is_feature_enabled("TAGGING_SYSTEM"),
-        )
         appbuilder.add_view(
             TagModelView,
             "Tags",
             label=__("Tags"),
             icon="",
             category_icon="",
+            category="Manage",
             menu_cond=lambda: feature_flag_manager.is_feature_enabled("TAGGING_SYSTEM"),
         )
         appbuilder.add_api(LogRestApi)