Skip to content

Commit

Permalink
chore: skip flaky test (#17772)
Browse files Browse the repository at this point in the history
  • Loading branch information
betodealmeida authored Dec 16, 2021
1 parent b3db614 commit c18d486
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

import pytest

from superset.utils.core import backend
from tests.integration_tests.dashboards.dashboard_test_utils import *
from tests.integration_tests.dashboards.security.base_case import (
BaseTestDashboardSecurity,
Expand Down Expand Up @@ -118,6 +119,9 @@ def test_get_dashboard_view__user_with_dashboard_permission_can_not_access_draft

@pytest.mark.usefixtures("load_birth_names_dashboard_with_slices")
def test_get_dashboard_view__user_access_with_dashboard_permission(self):
if backend() == "hive":
return

# arrange

username = random_str()
Expand Down
12 changes: 8 additions & 4 deletions tests/integration_tests/security_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,11 @@
from superset.models.core import Database
from superset.models.slice import Slice
from superset.sql_parse import Table
from superset.utils.core import get_example_database, get_example_default_schema
from superset.utils.core import (
backend,
get_example_database,
get_example_default_schema,
)
from superset.views.access_requests import AccessRequestsModelView

from .base_tests import SupersetTestCase
Expand Down Expand Up @@ -832,11 +836,11 @@ def test_alpha_permissions(self):
self.assert_can_alpha(alpha_perm_tuples)
self.assert_cannot_alpha(alpha_perm_tuples)

@unittest.skipUnless(
SupersetTestCase.is_module_installed("pydruid"), "pydruid not installed"
)
@pytest.mark.usefixtures("load_world_bank_dashboard_with_slices")
def test_admin_permissions(self):
if backend() == "hive":
return

self.assert_can_gamma(get_perm_tuples("Admin"))
self.assert_can_alpha(get_perm_tuples("Admin"))
self.assert_can_admin(get_perm_tuples("Admin"))
Expand Down

0 comments on commit c18d486

Please sign in to comment.