Skip to content

Commit

Permalink
fix failed tests
Browse files Browse the repository at this point in the history
  • Loading branch information
ofekisr committed Dec 27, 2021
1 parent c1a9c83 commit dd48e73
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions tests/integration_tests/charts/data/api_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -722,7 +722,7 @@ def test_with_virtual_table_with_colons_as_datasource(self):

@with_feature_flags(QUERY_CONTEXT_VALIDATION_SQL_EXPRESSION=True)
@pytest.mark.usefixtures("load_birth_names_dashboard_with_slices")
def test_when_actor_does_not_have_permission_to_datasource__401(self):
def test_when_actor_does_not_have_permission_to_datasource__403(self):
self.test_with_not_permitted_actor__403()

@with_feature_flags(QUERY_CONTEXT_VALIDATION_SQL_EXPRESSION=True)
Expand Down Expand Up @@ -756,7 +756,7 @@ def test_when_actor_has_permission_to_datasource__200(self):
"load_birth_names_dashboard_with_slices",
"load_world_bank_dashboard_with_slices",
)
def test_when_actor_does_not_have_permission_to_metric_datasource__401(self):
def test_when_actor_does_not_have_permission_to_metric_datasource__403(self):
self.logout()
self.login(username="gamma")
table = self.get_table("birth_names")
Expand All @@ -766,7 +766,7 @@ def test_when_actor_does_not_have_permission_to_metric_datasource__401(self):
)
self.query_context_payload["queries"][0]["metrics"].append(metric)
rv = self.post_assert_metric(CHART_DATA_URI, self.query_context_payload, "data")
assert rv.status_code == 401
assert rv.status_code == 403
self.revoke_role_access_to_table("Gamma", table)

@with_feature_flags(QUERY_CONTEXT_VALIDATION_SQL_EXPRESSION=True)
Expand Down

0 comments on commit dd48e73

Please sign in to comment.