Move unsaved chart id to a constant

apache · Jun 24, 2022 · eade95e · eade95e
1 parent adbe5a5
commit eade95e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/superset-frontend/src/explore/constants.ts b/superset-frontend/src/explore/constants.ts
@@ -162,3 +162,5 @@ export const FILTER_BOX_TRANSITION_SNOOZE_DURATION = 24 * 60 * 60 * 1000; // 24
 export const POPOVER_INITIAL_HEIGHT = 240;
 export const POPOVER_INITIAL_WIDTH = 320;
 export const UNRESIZABLE_POPOVER_WIDTH = 296;
+
+export const UNSAVED_CHART_ID = 0;
diff --git a/superset-frontend/src/explore/exploreUtils/index.js b/superset-frontend/src/explore/exploreUtils/index.js
@@ -34,12 +34,13 @@ import { URL_PARAMS } from 'src/constants';
 import {
   MULTI_OPERATORS,
   OPERATOR_ENUM_TO_OPERATOR_TYPE,
+  UNSAVED_CHART_ID,
 } from 'src/explore/constants';
 import { DashboardStandaloneMode } from 'src/dashboard/util/constants';
 
 export function getChartKey(explore) {
   const { slice, form_data } = explore;
-  return slice?.slice_id ?? form_data?.slice_id ?? 0;
+  return slice?.slice_id ?? form_data?.slice_id ?? UNSAVED_CHART_ID;
 }
 
 let requestCounter = 0;