Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query filters cannot be removed from saved slice #1181

Closed
the-dcruz opened this issue Sep 23, 2016 · 4 comments
Closed

Query filters cannot be removed from saved slice #1181

the-dcruz opened this issue Sep 23, 2016 · 4 comments
Labels
change:backend Requires changing the backend !deprecated-label:bug Deprecated label - Use #bug instead inactive Inactive for >= 30 days

Comments

@the-dcruz
Copy link
Contributor

Overview

If a slice is saved with some query filter specified, it is not possible to remove them from the slice.
I have verified this on master.

Steps to recreate

  1. Create new slice
  2. Add any query filter
  3. Save as new slice
  4. Edit newly saved slice
  5. Remove query filter by clicking the remove button
  6. Save and overwrite
  7. Reopen that slice and notice that the removed filters reappear

Location of Issue

https://github.com/airbnb/caravel/blob/master/caravel/models.py#L273
Since the filter keys no longer exist in the request parameters, the old filter parameters are not overwritten.
@the-dcruz
Copy link
Contributor Author

I can look into this if no one wants to pick it up soon.

@mistercrunch
Copy link
Member

Please do!

@bkyryliuk bkyryliuk added !deprecated-label:bug Deprecated label - Use #bug instead change:backend Requires changing the backend labels Sep 30, 2016
@graceguo-supercat graceguo-supercat self-assigned this Jun 28, 2017
@graceguo-supercat
Copy link

Verified this issue is fixed.

@graceguo-supercat graceguo-supercat removed their assignment Jul 5, 2017
@stale
Copy link

stale bot commented Apr 11, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label Apr 11, 2019
@stale stale bot closed this as completed Apr 18, 2019
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 17, 2021
@dependabot-preview @zhaoyongjie
chore(deps): bump @babel/compat-data from 7.13.12 to 7.14.7 (apache#1181
736f8bb 
)

Bumps [@babel/compat-data](https://github.com/babel/babel/tree/HEAD/packages/babel-compat-data) from 7.13.12 to 7.14.7.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.14.7/packages/babel-compat-data)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 24, 2021
@dependabot-preview @zhaoyongjie
chore(deps): bump @babel/compat-data from 7.13.12 to 7.14.7 (apache#1181
63d45f3 
)

Bumps [@babel/compat-data](https://github.com/babel/babel/tree/HEAD/packages/babel-compat-data) from 7.13.12 to 7.14.7.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.14.7/packages/babel-compat-data)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 25, 2021
@dependabot-preview @zhaoyongjie
chore(deps): bump @babel/compat-data from 7.13.12 to 7.14.7 (apache#1181
d408271 
)

Bumps [@babel/compat-data](https://github.com/babel/babel/tree/HEAD/packages/babel-compat-data) from 7.13.12 to 7.14.7.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.14.7/packages/babel-compat-data)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 26, 2021
@dependabot-preview @zhaoyongjie
chore(deps): bump @babel/compat-data from 7.13.12 to 7.14.7 (apache#1181
fef99dc 
)

Bumps [@babel/compat-data](https://github.com/babel/babel/tree/HEAD/packages/babel-compat-data) from 7.13.12 to 7.14.7.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.14.7/packages/babel-compat-data)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
This was referenced Feb 1, 2022
Open
Open
Closed
Open
@snyk-bot snyk-bot mentioned this issue Feb 21, 2022
Closed
@terrorizer1980 terrorizer1980 mentioned this issue Jun 22, 2022
Closed
This was referenced Sep 27, 2022
Open
Open
This was referenced Oct 6, 2022
Open
Open
Open
Open
@terrorizer1980 terrorizer1980 mentioned this issue May 24, 2023
Closed
@lili2311 lili2311 mentioned this issue Jul 4, 2023
Open
@terrorizer1980 terrorizer1980 mentioned this issue Jul 4, 2023
Closed
@mariasnyk mariasnyk mentioned this issue Jul 4, 2023
Open
@terrorizer1980 terrorizer1980 mentioned this issue Jul 5, 2023
Closed
@xiezhongfu xiezhongfu mentioned this issue Jul 5, 2023
Open
@xiezhongfu xiezhongfu mentioned this issue Nov 26, 2023
Open
@terrorizer1980 terrorizer1980 mentioned this issue Nov 29, 2023
Closed
@lili2311 lili2311 mentioned this issue Nov 29, 2023
Open
@terrorizer1980 terrorizer1980 mentioned this issue Nov 30, 2023
Closed
@xiezhongfu xiezhongfu mentioned this issue Dec 19, 2023
Open
This was referenced Dec 19, 2023
Closed
Closed
This was referenced Apr 29, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
change:backend Requires changing the backend !deprecated-label:bug Deprecated label - Use #bug instead inactive Inactive for >= 30 days
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mistercrunch @the-dcruz @bkyryliuk @graceguo-supercat