-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extracted Translation Order #27894
Comments
Yes, I'd love to see a PR to that effect. Any effort to make these translations more maintainable is a win in my book. I'm far from an expert with pybabel, so every time I touch this stuff, I feel "there's got to be a better way." |
lscheibel
added a commit
to lscheibel/superset
that referenced
this issue
Apr 15, 2024
lscheibel
added a commit
to lscheibel/superset
that referenced
this issue
Apr 15, 2024
lscheibel
added a commit
to lscheibel/superset
that referenced
this issue
Apr 15, 2024
…t translations order (apache#27894)
9 tasks
lscheibel
added a commit
to lscheibel/superset
that referenced
this issue
Apr 15, 2024
lscheibel
added a commit
to lscheibel/superset
that referenced
this issue
Apr 15, 2024
lscheibel
added a commit
to lscheibel/superset
that referenced
this issue
Apr 15, 2024
…t translations order (apache#27894)
lscheibel
added a commit
to lscheibel/superset
that referenced
this issue
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug description
Hello, I’ve noticed that when following the translations extraction process described in https://superset.apache.org/docs/contributing/translations/ the order of the items in the .pot file changes. This leads to a huge git diff, that is basically impossible to merge, even for small translation changes. Would you accept a PR that simply runs the pybabel extract command and updates the translation .pot and .po files with the what I assume to be correct order?
How to reproduce the bug
pybabel extract -F superset/translations/babel.cfg -o superset/translations/messages.pot -k _ -k __ -k t -k tn -k tct .
as stated in the docsScreenshots/recordings
No response
Superset version
master / latest-dev
Python version
3.10
Node version
16
Browser
Chrome
Additional context
I couldn't find any information on an expected order of the translation items but went through the git history and saw that for the most part it was in a different order.
Checklist
The text was updated successfully, but these errors were encountered: