Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't use custom columns in NOT GROUPED BY #420

Closed
aquach opened this issue Apr 30, 2016 · 3 comments
Closed

Can't use custom columns in NOT GROUPED BY #420

aquach opened this issue Apr 30, 2016 · 3 comments

Comments

@aquach
Copy link

aquach commented Apr 30, 2016

I've been playing around and familiarizing myself with Caravel for an hour or so, so I might be totally on the wrong track with how I'm using columns and metrics. I can't tell the difference between them: are metrics meant for rollup functions?

Anyways, I have a varchar column date formatted like 2015-01-01 and I created a custom column with an arbitrary SQL expression that transforms it into caravel_date like this: 2015-01-01 00:00:00.000000 so that I can use it in datetime computations. That's worked well, but I can't seem to use it in NOT GROUPED BY: instead of substituting the custom expression instead of the name, it uses the name directly:

SELECT caravel_date FROM transactions 

instead of

SELECT CONCAT(date, ' 00:00:00.000000') FROM transactions

I can use the column in GROUP BY and it works just fine, so this seems like a bug. Thanks for listening!

@mistercrunch
Copy link
Member

#421

@mistercrunch
Copy link
Member

Fixed on master branch

@aquach
Copy link
Author

aquach commented May 2, 2016

🙇 cheers!

zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 17, 2021
* feat: migrate xy-chart to use encodable (apache#420)

* feat: use encodable in BoxPlot

* feat: migrate legend

* docs: update storybook

* fix: label overlap

* fix: lint

* fix: remove comments

* fix: path

* feat: migrate scatterplot to use encodable (apache#421)

* feat: migrate scatter plot

(cherry picked from commit 0d607a60cdab8037ece7f29a74bef1c0a5432c5d)

* fix: legend

* feat: migrate line chart to use encodable (apache#427)

* feat: migrate line to use encodable

* fix: storybook ts

* fix: remove comment

* refactor: delete deprecated files (apache#430)

* refactor: delete outdated files

* feat: update index exports and add test

* refactor: delete more files

* fix: import order

* fix: update dependency

* fix: update dependency

* build: fix babel

* fix: remvoe comments

* fix: babel

* refactor: move files (apache#432)

* refactor: move files

* refactor: move files

* fix: small issues with charts post-migration (apache#433)

* fix: scatterplot issue

* fix: bump encodable and fix time scale nicing

* fix: issue with label rotation

* refactor: remove deep import

* fix: demo import

* feat: bump and remove unnecessary dependencies (apache#436)

* feat: bump dependencies

* feat: remove unnecessary dependencies
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 17, 2021
* fix: lint errors

* fix: lint

* fix: more lints

* fix: broken test

* fix: singleton type
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 24, 2021
* feat: migrate xy-chart to use encodable (apache#420)

* feat: use encodable in BoxPlot

* feat: migrate legend

* docs: update storybook

* fix: label overlap

* fix: lint

* fix: remove comments

* fix: path

* feat: migrate scatterplot to use encodable (apache#421)

* feat: migrate scatter plot

(cherry picked from commit 0d607a60cdab8037ece7f29a74bef1c0a5432c5d)

* fix: legend

* feat: migrate line chart to use encodable (apache#427)

* feat: migrate line to use encodable

* fix: storybook ts

* fix: remove comment

* refactor: delete deprecated files (apache#430)

* refactor: delete outdated files

* feat: update index exports and add test

* refactor: delete more files

* fix: import order

* fix: update dependency

* fix: update dependency

* build: fix babel

* fix: remvoe comments

* fix: babel

* refactor: move files (apache#432)

* refactor: move files

* refactor: move files

* fix: small issues with charts post-migration (apache#433)

* fix: scatterplot issue

* fix: bump encodable and fix time scale nicing

* fix: issue with label rotation

* refactor: remove deep import

* fix: demo import

* feat: bump and remove unnecessary dependencies (apache#436)

* feat: bump dependencies

* feat: remove unnecessary dependencies
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 24, 2021
* fix: lint errors

* fix: lint

* fix: more lints

* fix: broken test

* fix: singleton type
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 25, 2021
* feat: migrate xy-chart to use encodable (apache#420)

* feat: use encodable in BoxPlot

* feat: migrate legend

* docs: update storybook

* fix: label overlap

* fix: lint

* fix: remove comments

* fix: path

* feat: migrate scatterplot to use encodable (apache#421)

* feat: migrate scatter plot

(cherry picked from commit 0d607a60cdab8037ece7f29a74bef1c0a5432c5d)

* fix: legend

* feat: migrate line chart to use encodable (apache#427)

* feat: migrate line to use encodable

* fix: storybook ts

* fix: remove comment

* refactor: delete deprecated files (apache#430)

* refactor: delete outdated files

* feat: update index exports and add test

* refactor: delete more files

* fix: import order

* fix: update dependency

* fix: update dependency

* build: fix babel

* fix: remvoe comments

* fix: babel

* refactor: move files (apache#432)

* refactor: move files

* refactor: move files

* fix: small issues with charts post-migration (apache#433)

* fix: scatterplot issue

* fix: bump encodable and fix time scale nicing

* fix: issue with label rotation

* refactor: remove deep import

* fix: demo import

* feat: bump and remove unnecessary dependencies (apache#436)

* feat: bump dependencies

* feat: remove unnecessary dependencies
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 25, 2021
* fix: lint errors

* fix: lint

* fix: more lints

* fix: broken test

* fix: singleton type
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 26, 2021
* feat: migrate xy-chart to use encodable (apache#420)

* feat: use encodable in BoxPlot

* feat: migrate legend

* docs: update storybook

* fix: label overlap

* fix: lint

* fix: remove comments

* fix: path

* feat: migrate scatterplot to use encodable (apache#421)

* feat: migrate scatter plot

(cherry picked from commit 0d607a60cdab8037ece7f29a74bef1c0a5432c5d)

* fix: legend

* feat: migrate line chart to use encodable (apache#427)

* feat: migrate line to use encodable

* fix: storybook ts

* fix: remove comment

* refactor: delete deprecated files (apache#430)

* refactor: delete outdated files

* feat: update index exports and add test

* refactor: delete more files

* fix: import order

* fix: update dependency

* fix: update dependency

* build: fix babel

* fix: remvoe comments

* fix: babel

* refactor: move files (apache#432)

* refactor: move files

* refactor: move files

* fix: small issues with charts post-migration (apache#433)

* fix: scatterplot issue

* fix: bump encodable and fix time scale nicing

* fix: issue with label rotation

* refactor: remove deep import

* fix: demo import

* feat: bump and remove unnecessary dependencies (apache#436)

* feat: bump dependencies

* feat: remove unnecessary dependencies
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 26, 2021
* fix: lint errors

* fix: lint

* fix: more lints

* fix: broken test

* fix: singleton type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants