chore: cleanup FAB update perms #11155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
force-pushed
the
john-bodley--cleanup-FAB_UPDATE_PERMS
branch
from
3172ff8
to
7dd3679
Compare
john-bodley
changed the title
john-bodley
force-pushed
the
john-bodley--cleanup-FAB_UPDATE_PERMS
branch
from
7dd3679
to
8b91b26
Compare
john-bodley
commented
Oct 4, 2020
| @@ -552,7 +552,6 @@ def configure_fab(self) -> None: | |||
| appbuilder.indexview = SupersetIndexView | |||
| appbuilder.base_template = "superset/base.html" | |||
| appbuilder.security_manager_class = custom_sm | |||
| appbuilder.update_perms = False | |||
john-bodley
changed the title
john-bodley
force-pushed
the
john-bodley--cleanup-FAB_UPDATE_PERMS
branch
from
8b91b26
to
6051fd8
Compare
dpgaspar
approved these changes
Oct 6, 2020
villebro
approved these changes
Oct 7, 2020
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
* chore: Using cache factory method * chore: Deprecate outdated FAB_UPDATE_PERMS information Co-authored-by: John Bodley <[email protected]>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Superset has now configured FAB correctly in terms of when permissions should be updated, i.e., by default they shouldn't (per here) and only updated when running
superset init(per here) and thus it seems the documentation regardingFAB_UPDATE_PERMSis obsolete (it was originally added for a use case prior to FAB 2.0).BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
CI.
ADDITIONAL INFORMATION